Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the MachineConfigurationHomeDirectory to be changed and use a unique directory per test to isolate cross test issues #738

Conversation

nathanwoctopusdeploy
Copy link
Contributor

@nathanwoctopusdeploy nathanwoctopusdeploy commented Dec 13, 2023

Background

Allow the MachineConfigurationHomeDirectory to be changed and use a unique directory per test to isolate cross test issues

[sc-66742]

How to review this PR

Quality ✔️

Pre-requisites

  • I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
  • I have considered informing or consulting the right people, according to the ownership map.
  • I have considered appropriate testing for my change.

…nique directory per test to isolate cross test issues
@@ -5,9 +5,6 @@ namespace Octopus.Tentacle.Configuration
{
public enum ApplicationName
{
[Description("Octopus Server")]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legacy from a shared codebase

@@ -11,9 +11,6 @@ public static string GetWindowsServiceName(ApplicationName application, string?

switch (application)
{
case ApplicationName.OctopusServer:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legacy from a shared codebase

Copy link
Contributor

@sburmanoctopus sburmanoctopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanwoctopusdeploy nathanwoctopusdeploy enabled auto-merge (squash) December 14, 2023 03:31
Copy link

This pull request has been linked to Shortcut Story #66742: Tentacle Flakey Tests.

@nathanwoctopusdeploy nathanwoctopusdeploy merged commit 4b5049d into main Dec 14, 2023
48 checks passed
@nathanwoctopusdeploy nathanwoctopusdeploy deleted the sast/allow-machine-configuration-home-directory-to-be-changed branch December 14, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants