-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the MachineConfigurationHomeDirectory to be changed and use a unique directory per test to isolate cross test issues #738
Conversation
…nique directory per test to isolate cross test issues
@@ -5,9 +5,6 @@ namespace Octopus.Tentacle.Configuration | |||
{ | |||
public enum ApplicationName | |||
{ | |||
[Description("Octopus Server")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legacy from a shared codebase
@@ -11,9 +11,6 @@ public static string GetWindowsServiceName(ApplicationName application, string? | |||
|
|||
switch (application) | |||
{ | |||
case ApplicationName.OctopusServer: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legacy from a shared codebase
source/Octopus.Tentacle.Tests.Integration/MachineConfigurationHomeDirectoryTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request has been linked to Shortcut Story #66742: Tentacle Flakey Tests. |
Background
Allow the MachineConfigurationHomeDirectory to be changed and use a unique directory per test to isolate cross test issues
[sc-66742]
How to review this PR
Quality ✔️
Pre-requisites