Co-operatively cancel Tentacle Client Operations #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwoctopusdeploy
changed the base branch from
main
to
sast/test-exception-contracts
nathanwoctopusdeploy
force-pushed
the
sast/test-exception-contracts
branch
from
6b77e55 to
e138114
Compare
nathanwoctopusdeploy
force-pushed
the
sast/co-operativly-cancel-rpc-retries
branch
from
61593ed to
1d27a7b
Compare
nathanwoctopusdeploy
force-pushed
the
sast/test-exception-contracts
branch
from
e138114 to
e9dd8f0
Compare
nathanwoctopusdeploy
force-pushed
the
sast/co-operativly-cancel-rpc-retries
branch
from
1d27a7b to
f3a499b
Compare
nathanwoctopusdeploy
force-pushed
the
sast/test-exception-contracts
branch
6 times, most recently
from
ea8c002 to
9b19f36
Compare
nathanwoctopusdeploy
force-pushed
the
sast/co-operativly-cancel-rpc-retries
branch
from
501bda6 to
a2e09aa
Compare
| return false; | ||
| } | ||
|
|
||
| // TODO: Make this type safe |
There was a problem hiding this comment.
We have tests that will catch if this stops working but it needs to be improved. This will be done in a future PR
| return false; | ||
| } | ||
|
|
||
| // TODO: Make this type safe |
There was a problem hiding this comment.
We have tests that will catch if this stops working but it needs to be improved. This will be done in a future PR
nathanwoctopusdeploy
force-pushed
the
sast/co-operativly-cancel-rpc-retries
branch
2 times, most recently
from
3138dea to
acf9581
Compare
| @@ -28,7 +28,7 @@ | |||
| </Otherwise> | |||
| </Choose> | |||
| <ItemGroup> | |||
| <PackageReference Include="Halibut" Version="7.0.368" /> | |||
| <PackageReference Include="Halibut" Version="7.0.393-pull-576" /> | |||
There was a problem hiding this comment.
TODO Bump when OctopusDeploy/Halibut#576 merges
nathanwoctopusdeploy
force-pushed
the
sast/co-operativly-cancel-rpc-retries
branch
from
acf9581 to
e41c315
Compare
sburmanoctopus
approved these changes
Dec 7, 2023
nathanwoctopusdeploy
force-pushed
the
sast/co-operativly-cancel-rpc-retries
branch
from
e41c315 to
cc3a220
Compare
nathanwoctopusdeploy
deleted the
sast/co-operativly-cancel-rpc-retries
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the reverted PR #647 rebased
Background
[sc-58429]
Related to: OctopusDeploy/Halibut#525
Before Async Halibut was introduced, an RPC the was transferring (reading or writing over a TCP Connection) could not be cancelled in Halibut, only an RPC that was connecting could be cancelled.
Async Halibut, along with OctopusDeploy/Halibut#525 has added the ability to cancel RPC whether connecting or transferring. This allows the caller of Halibut to cancel an RPC with a cancellation token co-operatively.
Before Async Halibut, abandoning a Transferring RPC was the only way to "cancel" it. That is, run it as a different Task and walk away from the running Task if a cancellation was performed. While this method would allow the caller to regain control flow, it left the Task still executing and left IO operations on TCP Connection from Tentacle Client to Tentacle active.
Results
Before
Tentacle Client only supported the cancellation of connecting RPC. If an RPC was transferred, cancellation could not be performed, and the caller would have to wait for the RPC to complete.
Tentacle Client used the abandon technique for RPC Retry Timeouts, as it was the only reliable way to timeout the Retries and return control flow to the caller.
After
Tentacle Client will co-operatively cancel RPC to the Socket, stopping active reads and writes over TCP Connections.
Tentacle Client will co-operatively cancel RPC to the Socket when RPC Retries Timeout.
How to review this PR
Quality ✔️
Pre-requisites