Update Octopus.Tentacle dependencies to mitigate System.Drawing.Common CVE #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acodrington
force-pushed
the
sast/system-drawing-cve
branch
from
fbb7587 to
efe32a7
Compare
acodrington
force-pushed
the
sast/system-drawing-cve
branch
from
efe32a7 to
a0d1eb3
Compare
acodrington
changed the title
acodrington
requested review from
evolutionise,
raynhamdev,
david-staniec-octopus and
samdanaei
|
[sc-65659] |
|
This pull request has been linked to Shortcut Story #65659: Find where we missed updating System.ServiceProcess.ServiceController in Tentacle due to CVE. |
evolutionise
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove implicit dependencies on
System.Drawing.Commonto address CVE-2021-24112. This is achieved by updating the following references inOctopus.Tentacleto the latest versions:System.Diagnostics.EventLog(7.0.0 -> 8.0.0)System.DirectoryServices.AccountManagement(5.0.0 -> 8.0.0)System.Security.Cryptography.ProtectedData(4.5.0 -> 8.0.0)Background
There is a CVE lodged against the version of
System.Drawing.Commonbeing referenced.Results
Partially fixes Upgrade all usages of System.Drawing.Common in Tentacle.
The following will be completed in future PRs to fully address the CVE:
Octopus.Tentacle.Contractsmust be removed.Before
Octopus.Tentacleimplicitly referencesSystem.Drawing.Common5.0.0After
No implicit references to
System.Drawing.CommoninOctopus.TentacleHow to review this PR
Quality ✔️
Pre-requisites