Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add renovate GitHub action #687

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Add renovate GitHub action #687

merged 4 commits into from
Nov 27, 2023

Conversation

raynhamdev
Copy link
Contributor

@raynhamdev raynhamdev commented Nov 26, 2023

Background

As part of Sensible Default work, we'd like to add renovate to enable automatically dependency update in this repository.

Both Renovate and Dependabot are working well with GitHub. We chose Renovate because it is easier to configure for grouped PR than Dependabot. Additionally, Renovate has been used in many Octopus repositories (including Server) and has proved it is integrated well with OctoBob to approve/merge dependency update PRs automatically.

This PR adds Renovate GitHub action to the repo.

  • Run at 8AM, Mon-Fri
  • Auto-merge is not yet enabled.
  • Auto-approval by OctoBob is enabled.

I haven't enabled auto merge yet because I'd like to observe how integration with OctoBob works first. This is the part I was unable to test with my forked repository. Additional PR will be added later to enable auto-merge when we confirm this is working fine.

[sc-63579]

Results

Tested from a forked repository.
image

How to review this PR

Quality ✔️

Pre-requisites

  • I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
  • I have considered informing or consulting the right people, according to the ownership map.
  • I have considered appropriate testing for my change.

@raynhamdev raynhamdev self-assigned this Nov 26, 2023
Copy link

@raynhamdev raynhamdev marked this pull request as ready for review November 26, 2023 19:51
@raynhamdev raynhamdev requested a review from a team as a code owner November 26, 2023 19:51
@raynhamdev raynhamdev changed the title Ray/add renovate GitHub action Add renovate GitHub action Nov 26, 2023
Copy link
Contributor

@sburmanoctopus sburmanoctopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file apprrove-renovate-pull-request.yml looks like a typo? I.e. 2 Rs in apprrove.

FYI, I'm not reviewing this PR, as I don't know how this stuff works. I was just looking and saw this 😁

@raynhamdev
Copy link
Contributor Author

The file apprrove-renovate-pull-request.yml looks like a typo? I.e. 2 Rs in apprrove.

FYI, I'm not reviewing this PR, as I don't know how this stuff works. I was just looking and saw this 😁

@sburmanoctopus it's indeed very straightforward and they have good documentation here. You can skim through if interrested.

@sburmanoctopus sburmanoctopus requested a review from a team November 26, 2023 22:17
Copy link
Contributor

@evolutionise evolutionise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments, the only change I'd really like to see is the reviewers being the whole team rather than you specifically

renovate-config.js Outdated Show resolved Hide resolved
renovate-config.js Outdated Show resolved Hide resolved
renovate-config.js Show resolved Hide resolved
@raynhamdev raynhamdev requested review from a team and removed request for a team November 27, 2023 00:12
Copy link
Contributor

@evolutionise evolutionise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice work Ray, this was well-thought out and you did a great job of understanding the specific requirements for Tentacle vs other repos.

@raynhamdev raynhamdev merged commit 9c22938 into main Nov 27, 2023
40 checks passed
@raynhamdev raynhamdev deleted the ray/add-renovate-github-action branch November 27, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants