-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add renovate GitHub action #687
Conversation
This pull request has been linked to Shortcut Story #63579: Implement dependency auto-updating in the Tentacle repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file apprrove-renovate-pull-request.yml
looks like a typo? I.e. 2 Rs in apprrove
.
FYI, I'm not reviewing this PR, as I don't know how this stuff works. I was just looking and saw this 😁
@sburmanoctopus it's indeed very straightforward and they have good documentation here. You can skim through if interrested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor comments, the only change I'd really like to see is the reviewers being the whole team rather than you specifically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - nice work Ray, this was well-thought out and you did a great job of understanding the specific requirements for Tentacle vs other repos.
Background
As part of Sensible Default work, we'd like to add renovate to enable automatically dependency update in this repository.
Both Renovate and Dependabot are working well with GitHub. We chose Renovate because it is easier to configure for grouped PR than Dependabot. Additionally, Renovate has been used in many Octopus repositories (including Server) and has proved it is integrated well with OctoBob to approve/merge dependency update PRs automatically.
This PR adds Renovate GitHub action to the repo.
I haven't enabled auto merge yet because I'd like to observe how integration with OctoBob works first. This is the part I was unable to test with my forked repository. Additional PR will be added later to enable auto-merge when we confirm this is working fine.
[sc-63579]
Results
Tested from a forked repository.
How to review this PR
Quality ✔️
Pre-requisites