Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeploymentsRepository - allow FindBy to filter by tenants #804

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

DeploymentsRepository - allow FindBy to filter by tenants #804

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cb60208
Add a function to filter deployments by tenant
rain-on Nov 22, 2023
be1860b
add to sync repo
rain-on Nov 22, 2023
dfa8bef
fixed approved file
rain-on Nov 22, 2023
bc88ddf
add other approval file
rain-on Nov 22, 2023
ff26c28
fixed more
rain-on Nov 22, 2023
0812c23
change back
rain-on Nov 22, 2023
40af83a
add EOL at EOF
rain-on Nov 23, 2023
4465762
remove the line again
rain-on Nov 23, 2023
4d2c9eb
remove EOL
rain-on Nov 23, 2023
2d5f3d9
Correct EOF in NET framework surface area assent tests
skermajo Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions source/Octopus.Server.Client/Repositories/Async/DeploymentRepository.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ public async Task<ResourceCollection<DeploymentResource>> FindBy(string[] projec
{
return await Client.List<DeploymentResource>(await Repository.Link("Deployments").ConfigureAwait(false), new { skip, take, projects = projects ?? new string[0], environments = environments ?? new string[0] }).ConfigureAwait(false);
}

public async Task<ResourceCollection<DeploymentResource>> FindBy(string[] projects, string[] environments, string[] tenants, int skip = 0, int? take = null)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine this should also be added to the synchronous DeploymentRepository for consistency.

{
return await Client.List<DeploymentResource>(await Repository.Link("Deployments").ConfigureAwait(false), new { skip, take, projects = projects ?? new string[0], environments = environments ?? new string[0], tenants = tenants ?? new string[0] }).ConfigureAwait(false);
}

[Obsolete("This method is not a find all, it still requires paging. So it has been renamed to `FindBy`")]
public Task<ResourceCollection<DeploymentResource>> FindAll(string[] projects, string[] environments, int skip = 0, int? take = null)
Expand Down
Loading