Enable dotnetcore for framework #1406
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a lot of moving parts on this one. I've had a chat with Trent and we'll need to wait for this change to fix the Calamari Consolidation process when bundling a .Net6 package in a netframework build. Without this change we can overwrite dlls and break a lot of other things. This also requires Server changes to handle the reassembly of the calamari bundle which will have to be backported to Server. The alternative to this is that the deploy a package step as of 2024.4 supports running against the netcore versions of Calamari and netframework will be deprecated entirely. This is behind a feature toggle, but if the customer was willing to wait for 2024.4 they'll be able to fix this issue by just enabling that feature toggle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid throwing an exception when attempting to run .NET scripts in the .NET Framework build of Calamari. This is for Pre-Deploy scripts on Deploy a Package as this step does not support .NET Core
[SC-99263]