Add impulse noise mask #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons for impulse noise mask
Added unit tests in echopype/utils/mask_transformation.py covering the oned(), full(), dim2ax(), lin(), and log() functions.
There was a problem hiding this comment.
Code looks good. Test should be rewritten so that it also automatically downloads the test data if it doesn't exist - the file can be found at ftp.bas.ac.uk/rapidkrill/ek60/JR230-D20091215-T121917.raw and should be downloaded to /test_data/test_impulse_noise_mask_data/ - as it is, the process involves too much manual setup
Closed
ruxandra-valcu
approved these changes
Aug 17, 2023
simedroniraluca
approved these changes
Aug 17, 2023
|
Closing since no longer part of our workflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.