Move from nix-shell to flakes #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zupo
force-pushed
the
cleanup/flakes
branch
30 times, most recently
from
d8ced30 to
d23cc68
Compare
Also, remove `examples.md` as prompt is already tested in `README.md`.
zupo
force-pushed
the
cleanup/flakes
branch
2 times, most recently
from
1ec5f23 to
0c7d050
Compare
zupo
force-pushed
the
cleanup/flakes
branch
8 times, most recently
from
a1cb7b7 to
632833e
Compare
|
I think this is done? @domenkozar, @DavHau: am i missing something? |
DavHau
reviewed
Oct 26, 2023
There was a problem hiding this comment.
The readme still mentions 'default-pythonXX', but it has been renamed to 'appEnv-...'. Though I think the app should just be called 'tesh-pythonXXX'.
I think you can just merge it.
Next level would be to factor this out into one or more flake-parts modules with parametrization.
This was referenced Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.