Update branch with changes to main #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o parcels. The testing data uses only 5 levels, down to 4.7m depth. Particles would cause an out of bounds error in such a case, and be deleted. Updating the density of the particles lets them still sink, but not as quickly as before.
…, and our tests only run on two days of data, I have named the second week data 2020-01-05, even though the data is defined for 2020-01-11. Parcels will correctly interpolate the data temporally, but this is just to ensure the data is read by the constructors.
…xing kernel to be free to mix particles beyond 4m depth!
…ure particles aren't kicked beyond the depth field!
…errors when particles are kicked below the test dataset.
for more information, see https://pre-commit.ci
…els/PlasticParcels into fix_unit_test_failures
…ce the VerticalMixing kernel uses a 0.5m distance in the finite-differencing scheme. Also only running the test for 1d rather than 2.
Minor update to depth- and time-dependent unit testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.