PluginManager refactor v2 #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to remove all the old providers, as they're no longer needed, and introduce a new one that parses plugins that are packed and loads them accordingly. This did come as inspiration from the tmod format from tModLoader. Something that needs more discussion is plugin signing.
Here's the tmod format so you don't have to look for it
Right now, by default, it is not required; plugins can be packed without needing to be signed, and the server by default will also not require plugins to have a proper signature. Currently, to sign your plugin, you'll need an RSA private key written in the supported XML format needed to load them with c# (.netstandard2.0). This feature can be used differently than the way tModLoader uses them. Although I don't see a practical use for this, it does add an extra layer of complexity ~
Either way, this is tested and can be merged/improved upon. The whole goal of plugin packing is to make it easier to manage/load dependencies from plugins and to make a variety of other things easier too.