Implement player abilities packet #432
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9b134d9.
Tides
requested changes
Feb 27, 2024
Comment on lines
5
to
13
| [Flags] | ||
| public enum PlayerAbility | ||
| { | ||
| None = 0x00, | ||
| Invulnerable = 0x01, | ||
| Flying = 0x02, | ||
| AllowFlying = 0x04, | ||
| CreativeMode = 0x08 | ||
| } |
| } | ||
| } | ||
|
|
||
| public PlayerAbility Abilities { get; internal set; } |
There was a problem hiding this comment.
This should be made accessible through the api
Comment on lines
+17
to
+54
| public PlayerAbility Abilities { get; set; } = PlayerAbility.None; | ||
|
|
||
| public float FlyingSpeed { get; set; } = 0.05F; | ||
|
|
||
| public float FieldOfViewModifier { get; set; } = 0.1F; | ||
|
|
||
| public int Id { get; } | ||
|
|
||
| public PlayerAbilitiesPacket(bool toClient) | ||
| { | ||
| Id = toClient ? 0x36 : 0x20; | ||
| } | ||
|
|
||
| public void Serialize(MinecraftStream stream) | ||
| { | ||
| using var packetStream = new MinecraftStream(); | ||
| packetStream.WriteByte((byte)Abilities); | ||
| packetStream.WriteFloat(FlyingSpeed); | ||
| packetStream.WriteFloat(FieldOfViewModifier); | ||
|
|
||
| stream.Lock.Wait(); | ||
| stream.WriteVarInt(Id.GetVarIntLength() + (int)packetStream.Length); | ||
| stream.WriteVarInt(Id); | ||
| packetStream.Position = 0; | ||
| packetStream.CopyTo(stream); | ||
| stream.Lock.Release(); | ||
| } | ||
|
|
||
| public void Populate(MinecraftStream stream) | ||
| { | ||
| Abilities = (PlayerAbility) stream.ReadByte(); | ||
| } | ||
|
|
||
| public void Populate(byte[] data) | ||
| { | ||
| using var stream = new MinecraftStream(data); | ||
| Populate(stream); | ||
| } |
There was a problem hiding this comment.
Use the Field attribute on the packet properties so the source generators can write Serialize and Populate methods for you
There was a problem hiding this comment.
Apparently the SG does not like it because it does not have a parameter-less constructor.
There was a problem hiding this comment.
The Packet SG doesn't use/look at constructors 🤨
There was a problem hiding this comment.
You have to make sure the class is set to partial ^ ^
…erAbilitiesPacket # Conflicts: # Obsidian/Entities/Player.cs # Obsidian/Net/Packets/Play/Clientbound/PlayerAbilitiesPacket.cs
|
I will close this PR to fix the weird Git issues I am having (to not spam this PR), then re-open it again later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.