Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commands not finding valid executor #429

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Fix commands not finding valid executor #429

merged 4 commits into from
Mar 6, 2024

Conversation

Tides
Copy link
Member

@Tides Tides commented Feb 23, 2024

Fixes No valid executor was found due to there being no arguments. This makes sure to use first executor if there are no arguments

@github-actions github-actions bot added the commands Relates to Obsidian.Commands label Feb 23, 2024
Craftplacer
Craftplacer previously approved these changes Feb 24, 2024
Copy link
Collaborator

@Craftplacer Craftplacer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright, although a bit confused what the executor out variable is exactly doing, seems a bit repetitive/unnecessary the way it's being reassigned.

@Tides
Copy link
Member Author

Tides commented Feb 24, 2024

Looks alright, although a bit confused what the executor out variable is exactly doing, seems a bit repetitive/unnecessary the way it's being reassigned.

You're right 😅 Just fixed it up

@Tides
Copy link
Member Author

Tides commented Feb 24, 2024

Okay, now commands work fully with multiple args

@Tides Tides merged commit 31544a3 into master Mar 6, 2024
2 checks passed
@Tides Tides deleted the fix-commands branch March 6, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commands Relates to Obsidian.Commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants