Use collection initializers (IDE0028)

Obsidian.API/AI/AStarPath.cs

@@ -20,8 +20,8 @@ internal class AStarPath
 
     private readonly IWorld world;
 
-    private readonly List<Vector> validMoves = new()
-    {
+    private readonly List<Vector> validMoves =
+    [
         Vector.Left,
         Vector.Right,
         Vector.Forwards,
@@ -43,7 +43,7 @@ internal class AStarPath
         Vector.Backwards + Vector.Down,
         Vector.Left + Vector.Down,
         Vector.Right + Vector.Down,
-    };
+    ];
 
     public AStarPath(IWorld world)
     {
@@ -58,11 +58,11 @@ public List<Vector> GetPath(Vector startPos, Vector targetPos)
         // Out of range?
         float distanceSquared = (targetPos - startPos).MagnitudeSquared();
         if (distanceSquared > MaxRange * MaxRange)
-            return new List<Vector>();
+            return [];
 
 
-        List<Node> openList = new();
-        List<Node> closedList = new();
+        List<Node> openList = [];
+        List<Node> closedList = [];
 
         openList.Add(startNode);
 
@@ -130,7 +130,7 @@ public List<Vector> GetPath(Vector startPos, Vector targetPos)
             }
         }
 
-        return new List<Vector>();
+        return [];
     }
 
     private bool IsValidMove(Vector curPos, Vector nextPos)

Obsidian.API/Containers/BaseContainer.cs

@@ -14,7 +14,7 @@ public abstract class BaseContainer : IEnumerable<ItemStack>
 
     public Guid Uuid { get; } = Guid.NewGuid();
 
-    public List<IPlayer> Viewers { get; } = new();
+    public List<IPlayer> Viewers { get; } = [];
 
     public ItemStack? this[int index] { get => this.items[index]; set => this.items[index] = value; }
 

Obsidian.API/Crafting/Builders/CookingRecipeBuilder.cs

@@ -8,7 +8,7 @@ public sealed class CookingRecipeBuilder : BaseRecipeBuilder<SmeltingRecipe>, II
 
     private readonly SmeltingType type;
 
-    private Ingredient ingredient = new();
+    private Ingredient ingredient = [];
 
     private float experience;
 
@@ -62,7 +62,7 @@ public override SmeltingRecipe Build()
             Identifier = this.Identifier ?? throw new NullReferenceException("Recipe must have a name"),
             Type = type,
             Group = this.Group,
-            Result = this.Result != null ? new Ingredient { this.Result } : throw new NullReferenceException("Result is not set."),
+            Result = this.Result != null ? [this.Result] : throw new NullReferenceException("Result is not set."),
             Ingredient = this.ingredient,
             Experience = this.experience,
             CookingTime = this.cookingTime,

Obsidian.API/Crafting/Builders/CuttingRecipeBuilder.cs

@@ -4,7 +4,7 @@ namespace Obsidian.API.Crafting.Builders;
 
 public sealed class CuttingRecipeBuilder : BaseRecipeBuilder<CuttingRecipe>, IIngredientRecipe<IOutputCountRecipe<CuttingRecipe>>, IOutputCountRecipe<CuttingRecipe>
 {
-    private Ingredient ingredient = new();
+    private Ingredient ingredient = [];
 
     public int Count { get; set; }
 
@@ -37,7 +37,7 @@ public override CuttingRecipe Build()
             Identifier = this.Identifier ?? throw new NullReferenceException("Name must not be null"),
             Type = CraftingType.Stonecutting,
             Group = this.Group,
-            Result = this.Result != null ? new Ingredient { this.Result } : throw new NullReferenceException("Result is not set."),
+            Result = this.Result != null ? [this.Result] : throw new NullReferenceException("Result is not set."),
             Ingredient = this.ingredient ?? throw new NullReferenceException("Ingredient must not be null"),
             Count = this.Count
         };

Obsidian.API/Crafting/Builders/ShapedRecipeBuilder.cs

@@ -7,9 +7,9 @@ public sealed class ShapedRecipeBuilder : BaseRecipeBuilder<ShapedRecipe>, IPatt
 {
     private readonly CraftingBookCategory category;
 
-    private readonly List<string> pattern = new();
+    private readonly List<string> pattern = [];
 
-    private readonly Dictionary<char, Ingredient> key = new();
+    private readonly Dictionary<char, Ingredient> key = [];
 
     private bool showNotification;
 
@@ -61,7 +61,7 @@ public override ShapedRecipe Build()
             Identifier = this.Identifier ?? throw new NullReferenceException("Recipe must have a name"),
             Type = CraftingType.CraftingShaped,
             Group = this.Group,
-            Result = this.Result != null ? new Ingredient { this.Result } : throw new NullReferenceException("Result is not set."),
+            Result = this.Result != null ? [this.Result] : throw new NullReferenceException("Result is not set."),
             Pattern = new ReadOnlyCollection<string>(new List<string>(this.pattern)),
             Key = new ReadOnlyDictionary<char, Ingredient>(new Dictionary<char, Ingredient>(this.key)),
             Category = this.category,

Obsidian.API/Crafting/Builders/ShapelessRecipeBuilder.cs

@@ -7,7 +7,7 @@ public sealed class ShapelessRecipeBuilder : BaseRecipeBuilder<ShapelessRecipe>,
 {
     private readonly CraftingBookCategory category;
 
-    private readonly List<Ingredient> ingredients = new();
+    private readonly List<Ingredient> ingredients = [];
 
     private ShapelessRecipeBuilder(CraftingBookCategory category) => this.category = category;
 
@@ -31,7 +31,7 @@ public override ShapelessRecipe Build()
             Identifier = this.Identifier ?? throw new NullReferenceException("Recipe must have a name"),
             Type = CraftingType.CraftingShapeless,
             Group = this.Group,
-            Result = this.Result != null ? new Ingredient { this.Result } : throw new NullReferenceException("Result is not set."),
+            Result = this.Result != null ? [this.Result] : throw new NullReferenceException("Result is not set."),
             Ingredients = new ReadOnlyCollection<Ingredient>(new List<Ingredient>(this.ingredients)),
             Category = this.category
         };

Obsidian.API/Crafting/Builders/SmithingTransformRecipeBuilder.cs

@@ -7,9 +7,9 @@ public sealed class SmithingTransformRecipeBuilder : BaseRecipeBuilder<SmithingT
     IUpgradeIngredientRecipe<SmithingTransformRecipe>,
     ITemplateIngredientRecipe<SmithingTransformRecipe>
 {
-    private Ingredient @base = new();
-    private Ingredient addition = new();
-    private Ingredient template = new();
+    private Ingredient @base = [];
+    private Ingredient addition = [];
+    private Ingredient template = [];
 
     private SmithingTransformRecipeBuilder() { }
 
@@ -55,7 +55,7 @@ public override SmithingTransformRecipe Build()
             Base = this.@base,
             Addition = this.addition,
             Template = template,
-            Result = this.Result != null ? new Ingredient { this.Result } : throw new NullReferenceException("Result is not set.")
+            Result = this.Result != null ? [this.Result] : throw new NullReferenceException("Result is not set.")
         };
     }
 }

Obsidian.API/Crafting/Ingredient.cs

@@ -10,7 +10,7 @@ public class Ingredient : IEnumerable<ItemStack>
 
     public Ingredient()
     {
-        this.items = new List<ItemStack>();
+        this.items = [];
     }
 
     public void Add(ItemStack item) => this.items.Add(item);

Obsidian.API/_Types/ChatMessage.cs

@@ -171,15 +171,15 @@ public static string ReformatAmpersandPrefixes(string originalText)
 
     public ChatMessage AddChatComponent(ChatMessage message)
     {
-        this.With ??= new();
+        this.With ??= [];
         this.With.Add(message);
 
         return this;
     }
 
     public ChatMessage AddChatComponent(IEnumerable<ChatMessage> message)
     {
-        this.With ??= new();
+        this.With ??= [];
         this.With.AddRange(message);
 
         return this;
@@ -188,7 +188,7 @@ public ChatMessage AddChatComponent(IEnumerable<ChatMessage> message)
 
     public ChatMessage AddExtra(ChatMessage message)
     {
-        Extra ??= new List<ChatMessage>();
+        Extra ??= [];
         Extra.Add(message);
 
         return this;

Obsidian.API/_Types/Inventory/ItemMetaBuilder.cs

@@ -18,12 +18,12 @@ public class ItemMetaBuilder
 
     public IReadOnlyList<ChatMessage> Lore { get; }
 
-    private readonly Dictionary<EnchantmentType, Enchantment> enchantments = new Dictionary<EnchantmentType, Enchantment>();
-    private readonly Dictionary<EnchantmentType, Enchantment> storedEnchantments = new Dictionary<EnchantmentType, Enchantment>();
+    private readonly Dictionary<EnchantmentType, Enchantment> enchantments = [];
+    private readonly Dictionary<EnchantmentType, Enchantment> storedEnchantments = [];
 
-    private readonly List<string> canDestroy = new List<string>();
+    private readonly List<string> canDestroy = [];
 
-    private readonly List<ChatMessage> lore = new List<ChatMessage>();
+    private readonly List<ChatMessage> lore = [];
 
     public ItemMetaBuilder()
     {

Obsidian.API/_Types/Traversal.cs

@@ -33,7 +33,7 @@ private static float Frac1(float x)
     public List<VectorF> Run()
     {
 
-        List<VectorF> blocks = new List<VectorF>();
+        List<VectorF> blocks = [];
 
         float tMaxX, tMaxY, tMaxZ, tDeltaX, tDeltaY, tDeltaZ;
         VectorF voxel = new VectorF();

Obsidian.Nbt/NbtCompound.cs

@@ -5,7 +5,7 @@ namespace Obsidian.Nbt;
 
 public class NbtCompound : INbtTag, IEnumerable<KeyValuePair<string, INbtTag>>
 {
-    private readonly Dictionary<string, INbtTag> children = new();
+    private readonly Dictionary<string, INbtTag> children = [];
 
     public int Count => this.children.Count;
 

Obsidian.Nbt/NbtList.cs

@@ -5,7 +5,7 @@ namespace Obsidian.Nbt;
 
 public class NbtList : INbtTag, IList<INbtTag>
 {
-    private readonly List<INbtTag> baseList = new();
+    private readonly List<INbtTag> baseList = [];
 
     public int Count => this.baseList.Count;
 

Obsidian.SourceGenerators/Packets/MethodsRegistry.cs

@@ -7,8 +7,8 @@ internal sealed class MethodsRegistry
     public IReadOnlyList<Method> WriteMethods => writeMethods;
     public IReadOnlyList<Method> ReadMethods => readMethods;
 
-    private readonly List<Method> writeMethods = new();
-    private readonly List<Method> readMethods = new();
+    private readonly List<Method> writeMethods = [];
+    private readonly List<Method> readMethods = [];
 
     public bool TryGetWriteMethod(Property property, out Method method)
     {

Obsidian.SourceGenerators/Registry/Models/BlockProperty.cs

@@ -15,7 +15,7 @@ internal class BlockProperty
     private const string BooleanName = "bool";
     private const string IntegerName = "int";
 
-    internal static Dictionary<string, string[]> enumValuesCache = new();
+    internal static Dictionary<string, string[]> enumValuesCache = [];
 
     private BlockProperty(string name, string tag, string type, string[] values, int? customOffset = null, bool isBooleanToggled = true)
     {

Obsidian.SourceGenerators/Registry/Models/Codec.cs

@@ -7,7 +7,7 @@ internal sealed class Codec : IHasName, IRegistryItem
 
     public int RegistryId { get; }
 
-    public Dictionary<string, JsonElement> Properties { get; set; } = new();
+    public Dictionary<string, JsonElement> Properties { get; set; } = [];
 
     public Codec(string name, int registryId)
     {

Obsidian.SourceGenerators/Registry/Models/Customizations.cs

@@ -7,7 +7,7 @@ internal static class Customizations
 
     static Customizations()
     {
-        BannedNames = new();
+        BannedNames = [];
         foreach (Type type in typeof(int).Assembly.GetTypes())
         {
             BannedNames.Add(type.Name);

Obsidian.SourceGenerators/Registry/Models/Tag.cs

@@ -65,7 +65,7 @@ public static Tag Get(JsonProperty property, Dictionary<string, ITaggable> tagga
     private static void UpdateMissedTags(string propertyName, string valueTag, Dictionary<string, List<string>> missedTags)
     {
         if (!missedTags.ContainsKey(propertyName))
-            missedTags.Add(propertyName, new() { valueTag });
+            missedTags.Add(propertyName, [valueTag]);
         else
             missedTags[propertyName].Add(valueTag);
     }

Obsidian/Blocks/BlockMetaBuilder.cs

@@ -14,9 +14,9 @@ public class BlockMetaBuilder
 
     public IReadOnlyList<string> CanPlaceOn { get; }
 
-    private readonly List<string> canPlaceOn = new List<string>();
+    private readonly List<string> canPlaceOn = [];
 
-    private readonly List<ChatMessage> lore = new List<ChatMessage>();
+    private readonly List<ChatMessage> lore = [];
 
     public BlockMetaBuilder()
     {

Obsidian/BossBar.cs

@@ -10,7 +10,7 @@ public class BossBar : IBossBar
     private Server server;
 
     private BossBarRemoveAction removeAction;
-    public HashSet<Guid> Players { get; } = new();
+    public HashSet<Guid> Players { get; } = [];
 
     public Guid Uuid { get; } = Guid.NewGuid();
 

Obsidian/Client.cs

@@ -177,13 +177,13 @@ public Client(ConnectionContext connectionContext, ServerConfiguration config, i
         id = playerId;
         Server = originServer;
 
-        LoadedChunks = new();
+        LoadedChunks = [];
         packetCryptography = new();
         handler = new(config);
         networkStream = new(connectionContext.Transport);
         minecraftStream = new(networkStream);
 
-        missedKeepAlives = new List<long>();
+        missedKeepAlives = [];
         var linkOptions = new DataflowLinkOptions { PropagateCompletion = true };
         var blockOptions = new ExecutionDataflowBlockOptions { CancellationToken = cancellationSource.Token, EnsureOrdered = true };
         var sendPacketBlock = new ActionBlock<IClientboundPacket>(packet =>
@@ -634,7 +634,7 @@ internal void SendKeepAlive(DateTimeOffset time)
 
     internal Task RemovePlayerFromListAsync(IPlayer player) => QueuePacketAsync(new PlayerInfoRemovePacket
     {
-        UUIDs = new() { player.Uuid }
+        UUIDs = [player.Uuid]
     });
 
     internal async Task AddPlayerToListAsync(IPlayer player)

Obsidian/Commands/CommandNode.cs

@@ -15,7 +15,7 @@ public class CommandNode
 
     public CommandNodeType Type { get; set; }
 
-    public HashSet<CommandNode> Children = new();
+    public HashSet<CommandNode> Children = [];
 
     public async Task CopyToAsync(MinecraftStream stream)
     {

Obsidian/Commands/Framework/CommandHandler.cs

@@ -20,8 +20,8 @@ public class CommandHandler
     public CommandHandler()
     {
         _commandParser = new CommandParser(DefaultPrefix);
-        _commands = new List<Command>();
-        _argumentParsers = new List<BaseArgumentParser>();
+        _commands = [];
+        _argumentParsers = [];
         _prefix = DefaultPrefix;
 
         // Find all predefined argument parsers

Obsidian/Commands/Framework/Entities/Command.cs

@@ -35,7 +35,7 @@ public Command(string name, string[] aliases, string description, string usage,
         Plugin = plugin;
         ParentType = parentType;
         AllowedIssuers = allowedIssuers;
-        Overloads = new List<MethodInfo>();
+        Overloads = [];
     }
 
     public bool CheckCommand(string[] input, Command? parent)

Obsidian/Entities/FallingBlock.cs

@@ -18,7 +18,7 @@ public sealed partial class FallingBlock : Entity
 
     private readonly float windResFactor = 0.98F;
 
-    private HashSet<Vector> checkedBlocks = new();
+    private HashSet<Vector> checkedBlocks = [];
 
     public FallingBlock(VectorF position) : base()
     {

Obsidian/Entities/Player.cs

@@ -32,7 +32,7 @@ public sealed partial class Player : Living, IPlayer
     /// </summary>
     protected ILogger Logger { get; private set; }
 
-    internal HashSet<int> visiblePlayers = new();
+    internal HashSet<int> visiblePlayers = [];
 
     //TODO: better name??
     internal short inventorySlot = 36;
@@ -55,7 +55,7 @@ public sealed partial class Player : Living, IPlayer
 
     public BaseContainer? OpenedContainer { get; set; }
 
-    public List<SkinProperty> SkinProperties { get; set; } = new();
+    public List<SkinProperty> SkinProperties { get; set; } = [];
 
     public Vector? LastDeathLocation { get; set; }
 
@@ -954,7 +954,7 @@ internal async Task<bool> UpdateChunksAsync(bool unloadAll = false, int distance
             client.LoadedChunks.Clear();
         }
 
-        List<(int X, int Z)> clientNeededChunks = new();
+        List<(int X, int Z)> clientNeededChunks = [];
         List<(int X, int Z)> clientUnneededChunks = new(client.LoadedChunks);
 
         (int playerChunkX, int playerChunkZ) = Position.ToChunkCoord();

Obsidian/Events/AsyncEvent.T.cs

@@ -9,7 +9,7 @@ public sealed class AsyncEvent<T> : IEventRegistry
     public string? Name { get; } // Name must be set in order to be visible to plugins
 
     private readonly SemaphoreSlim semaphore = new(1);
-    private readonly List<Hook<T>> hooks = new();
+    private readonly List<Hook<T>> hooks = [];
     private readonly Action<AsyncEvent<T>, Exception>? exceptionHandler;
 
     public AsyncEvent()