Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Test for XXE #710

Closed
wants to merge 14 commits into from
Closed

Added Test for XXE #710

wants to merge 14 commits into from

Conversation

DotDotSlashRepo
Copy link
Contributor

@DotDotSlashRepo DotDotSlashRepo commented Jan 12, 2021

This PR covers issue #8

  • This PR handles the issue and requires no additional PRs. Refer TODOs
  • You have validated the need for this change.

What did this PR accomplish?

  • Added test case for XXE

TODO

  1. Edit top level page to link to test case.
  2. This test case has overlap with WSTG-INPV-07 , XML injection. WSTG-INPV-07 is to be modified to eliminate duplication.
  3. Need to re-order test case, XXE makes more sense to be after XML injection

Thank you for your contribution!

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

DotDotSlashRepo and others added 6 commits February 5, 2021 23:46
…n_Testing/20-Testing_for_XXE_Injection.md

Co-authored-by: Rick M <[email protected]>
…n_Testing/20-Testing_for_XXE_Injection.md

Co-authored-by: Rick M <[email protected]>
…n_Testing/20-Testing_for_XXE_Injection.md

Co-authored-by: Rick M <[email protected]>
…n_Testing/20-Testing_for_XXE_Injection.md

Co-authored-by: Rick M <[email protected]>
…n_Testing/20-Testing_for_XXE_Injection.md

Co-authored-by: Rick M <[email protected]>
…n_Testing/20-Testing_for_XXE_Injection.md

Co-authored-by: Rick M <[email protected]>
@github-actions
Copy link

github-actions bot commented Feb 5, 2021

Following links are broken:
FILE:document/4-Web_Application_Security_Testing/07-Input_Validation_Testing/20-Testing_for_XXE_Injection.md
[✖] https://www.securityfocus.com/archive/1/297714 → Status: 0

DotDotSlashRepo and others added 4 commits February 5, 2021 23:51
…n_Testing/20-Testing_for_XXE_Injection.md

Co-authored-by: Rick M <[email protected]>
…n_Testing/20-Testing_for_XXE_Injection.md

Co-authored-by: Rick M <[email protected]>
…n_Testing/20-Testing_for_XXE_Injection.md

Co-authored-by: Rick M <[email protected]>
…n_Testing/20-Testing_for_XXE_Injection.md

Co-authored-by: Rick M <[email protected]>
@DotDotSlashRepo
Copy link
Contributor Author

TODO

Edit top level page to link to test case.
This test case has overlap with WSTG-INPV-07 , XML injection. WSTG-INPV-07 is to be modified to eliminate duplication.
Need to re-order test case, XXE makes more sense to be after XML injection

@kingthorin : Can I go ahead with these ?

@kingthorin
Copy link
Collaborator

kingthorin commented Feb 5, 2021

I'm good with you addressing duplicate content.
However re-ordering things should wait until we are headed to 5.x. Currently we are still planning further 4.x releases, so maybe just create an issue and we can assign it to the 5.0 milestone.

@github-actions
Copy link

Please comment if you are still working on this PR, as it has been inactive for 30 days. To give everyone a chance to contribute, we are releasing it for new contributors to take over.

@github-actions
Copy link

Please comment if you are still working on this PR, as it has been inactive for 30 days. To give everyone a chance to contribute, we are releasing it for new contributors to take over.

@kingthorin kingthorin added the new New content to write label Aug 25, 2021
@kingthorin
Copy link
Collaborator

@DotDotSlashRepo do you intend to finish this?

@kingthorin
Copy link
Collaborator

@DotDotSlashRepo do you intend to finish this?


The followings source code keyword may apply to C.

- libxml2: xmlCtxtReadMemory,xmlCtxtUseOptions,xmlParseInNodeContext,xmlReadDoc,xmlReadFd,xmlReadFile ,xmlReadIO,xmlReadMemory, xmlCtxtReadDoc ,xmlCtxtReadFd,xmlCtxtReadFile,xmlCtxtReadIO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • libxml2: xmlCtxtReadMemory, xmlCtxtUseOptions, xmlParseInNodeContext, xmlReadDoc, xmlReadFd, xmlReadFile, xmlReadIO, xmlReadMemory, xmlCtxtReadDoc, xmlCtxtReadFd, xmlCtxtReadFile, xmlCtxtReadIO

The followings source code keyword may apply to C.

- libxml2: xmlCtxtReadMemory,xmlCtxtUseOptions,xmlParseInNodeContext,xmlReadDoc,xmlReadFd,xmlReadFile ,xmlReadIO,xmlReadMemory, xmlCtxtReadDoc ,xmlCtxtReadFd,xmlCtxtReadFile,xmlCtxtReadIO
- libxerces-c: XercesDOMParser, SAXParser, SAX2XMLReader
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • libxerces-c: XercesDOMParser, SAXParser, SAX2XMLReader

@ThunderSon
Copy link
Collaborator

@RiieCco might you have some time to give this a look?

@kingthorin what is still needed for this? I'll be giving this a look as well.

@ThunderSon ThunderSon self-requested a review April 19, 2022 22:11
@kingthorin
Copy link
Collaborator

Comments from Feb 5th and Rejah’s more recent comments.

@ThunderSon
Copy link
Collaborator

Alright. Let's re-review that comment, as that seems to be creating an issue, and is not a blocker right now.
Let's try to recall the exact concern and then move this.
This is a good addition, I'll try to review this ASAP.

@kingthorin
Copy link
Collaborator

kingthorin commented Apr 19, 2022

It was this discussion:

TODO
Edit top level page to link to test case.
This test case has overlap with WSTG-INPV-07 , XML injection. WSTG-INPV-07 is to be modified to eliminate duplication.
Need to re-order test case, XXE makes more sense to be after XML injection


I'm good with you addressing duplicate content.
However re-ordering things should wait until we are headed to 5.x. Currently we are still planning further 4.x releases, so maybe just create an issue and we can assign it to the 5.0 milestone.

@DotDotSlashRepo DotDotSlashRepo closed this by deleting the head repository Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new New content to write
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants