Feat add gcp support #340
Merged
Feat add gcp support #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Wrongsecrets files Signed-off-by: osamamagdy <[email protected]>
Enable autoscaling and csi driver Signed-off-by: osamamagdy <[email protected]>
Signed-off-by: osamamagdy <[email protected]>
Signed-off-by: osamamagdy <[email protected]>
Signed-off-by: osamamagdy <[email protected]>
Signed-off-by: osamamagdy <[email protected]>
Signed-off-by: osamamagdy <[email protected]>
commjoen
requested changes
Sep 16, 2023
There was a problem hiding this comment.
Initial review done, that's a big lift @osamamagdy ! Thank you!
Can you please have a look at the feedback?
Signed-off-by: osamamagdy <[email protected]>
…crets-ctf-party into feat--add-gcp-support Signed-off-by: osamamagdy <[email protected]>
osamamagdy
force-pushed
the
feat--add-gcp-support
branch
from
0df4463 to
6f68c47
Compare
Signed-off-by: osamamagdy <[email protected]>
…crets-ctf-party into feat--add-gcp-support Signed-off-by: osamamagdy <[email protected]>
osamamagdy
force-pushed
the
feat--add-gcp-support
branch
2 times, most recently
from
9825fa5 to
37866f8
Compare
osamamagdy
force-pushed
the
feat--add-gcp-support
branch
from
2441fa1 to
b86f930
Compare
Signed-off-by: osamamagdy <[email protected]>
osamamagdy
force-pushed
the
feat--add-gcp-support
branch
from
b86f930 to
41f8627
Compare
bendehaan
approved these changes
Sep 19, 2023
commjoen
approved these changes
Sep 19, 2023
|
Fixes #157 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Checklist: