Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation notes and status for MASTG v1 tests #3089

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

cpholguera
Copy link
Collaborator

@cpholguera cpholguera commented Dec 11, 2024

Introduce deprecation notes and status indicators for MASTG tests, including draft and deprecated banners.

The deprecated banners for MASTG v1 tests also list the V2 tests covering for the old test.

Update theme and extra sections to reflect these statuses.

@cpholguera cpholguera requested a review from Copilot December 11, 2024 12:46

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no suggestions.

Files not reviewed (3)
  • tests/android/MASVS-STORAGE/MASTG-TEST-0001.md: Evaluated as low risk
  • tests/ios/MASVS-RESILIENCE/MASTG-TEST-0083.md: Evaluated as low risk
  • tests/android/MASVS-STORAGE/MASTG-TEST-0003.md: Evaluated as low risk
Comments skipped due to low confidence (5)

docs/hooks/create_dynamic_tables.py:189

  • The default status 'current' should be defined in the project's documentation or guidelines to ensure consistency. Consider using a more descriptive status if 'current' is not explicitly defined.
frontmatter['status'] = frontmatter.get('status', 'current')

docs/hooks/create_dynamic_tables.py:242

  • The default status 'new' should be defined in the project's documentation or guidelines to ensure consistency. Consider using a more descriptive status if 'new' is not explicitly defined.
frontmatter['status'] = frontmatter.get('status', 'new')

docs/hooks/maswe-beta-banner.py:66

  • [nitpick] The function name 'get_maswe_draft_banner' is ambiguous. Consider renaming it to 'get_maswe_draft_weakness_banner' for clarity.
def get_maswe_draft_banner(meta):

docs/hooks/maswe-beta-banner.py:113

  • [nitpick] The function name 'get_tests_draft_banner' is ambiguous. Consider renaming it to 'get_mastg_tests_draft_banner' for clarity.
def get_tests_draft_banner(meta):

docs/hooks/maswe-beta-banner.py:139

  • [nitpick] The function name 'get_v1_deprecated_tests_banner' is ambiguous. Consider renaming it to 'get_mastg_v1_deprecated_tests_banner' for clarity.
def get_v1_deprecated_tests_banner(meta):
@cpholguera cpholguera merged commit 7328dfc into master Dec 11, 2024
4 checks passed
@cpholguera cpholguera deleted the add-draft-deprec-banners branch December 11, 2024 12:49
@cpholguera cpholguera changed the title Add deprecation notes and status for MASTG tests Add deprecation notes and status for MASTG v1 tests Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant