Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set depth to 0 & add last updated to the tests table #2564

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

cpholguera
Copy link
Collaborator

@cpholguera cpholguera commented Feb 20, 2024

We're updating the fetch depth to 0 for our website builder Action since this is the only way we have come up with to display "Last Updated" as seen here: https://mas.owasp.org/MASTG/tests/

@cpholguera cpholguera changed the title Set depth to 0 to fix latest updated files Set depth to 0 & add last updated to the tests table Feb 20, 2024
@cpholguera cpholguera merged commit b021623 into master Feb 20, 2024
3 of 4 checks passed
@cpholguera cpholguera deleted the cpholguera-patch-1 branch February 20, 2024 12:26
@cpholguera cpholguera mentioned this pull request Feb 20, 2024
6 tasks
@anantshri
Copy link
Collaborator

@cpholguera curious why are we going for fetch-depth = 0

https://github.com/actions/checkout?tab=readme-ov-file#Fetch-all-history-for-all-tags-and-branches

depth zero is only recommended if we really need all of history. depth = 1 or others are use to reduce the disk and processing time if i recall right?

@cpholguera
Copy link
Collaborator Author

Hi @anantshri, that's correct. However, this is the only way we have come up with to display "Last Updated" as you can see here: https://mas.owasp.org/MASTG/tests/

If you have other ideas to achieve the same, they are very welcome!

@anantshri
Copy link
Collaborator

ah we do need history in that case unless we maintain a file somewhere in the repository that gets this details updated in it when an entry change but i guess that might be a bit of overkill.

thanks for taking time to update here.

@cpholguera
Copy link
Collaborator Author

@anantshri, thank you for keeping an eye on the project. I really appreciate it. Please don't hesitate to report such things in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants