-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for docker installation #31
Conversation
Signed-off-by: Mostafa Hussein <[email protected]>
great contribution, @rezasp please consider this PR. |
Hi @mostafahussein, once again thanks for your contribution, it's a great idea to have dockerfile on this project, here are my comments on this PR.
Thank you. |
@Ali-Razmjoo , Can I change it to author instead of maintainer ? |
@rezasp should tell about this policy, in other projects usually contributor can add their name as a comment in the code, but Reza please guide @mostafahussein regarding this project. |
for the
This will makes you able to access the reports through the host, also you can use docker-compose as it provides an easier way to handle docker instead of the docker cli itself In order to modify the entrypoint without modifying the dockerfile you can do the following:
I think it will be suitable to add these examples in the readme file itself without modifying the current dockerfile. what do you think ? Update: |
I talked to Reza, he also confirmed, it's ok to add your name as a comment in Dockerfile. in that case please modify the readme file and add the docker section. |
@Ali-Razmjoo , I have updated the dockerfile and the readme kindly check it and let me if there is any modification needed |
@mostafahussein thanks for your contribution. @rezasp it's ready to merge. please consider. |
Hello, Thank you for your contribution, PR Merged. Best Regards. |
This PR adds support for installing
joomscan
as a docker container