Edited CssSchema to preserve hsl() and hsla() functions #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#206) * Do not lcase element or attribute names that match SVG or MathML names exactly > Currently all names are converted to lowercase which is ok when > you're using it for HTML only, but if there is an SVG image nested > inside the HTML it breaks. For example, when `viewBox` attribute is > converted to `viewbox` the image is not displayed correctly. This commit splits *HtmlLexer*.*canonicalName* into variants which preserve items on whitelists derived from the SVG and MathML specifications, and adjusts callers of *canonicalName* to use the appropriate variant. Fixes #182 * add unittests for mixed-case SVG names
aakritisi
changed the title
|
I believe the CI failures are spurious, due to a vulnerability in Junit which does not affect us
but we have vulnerability scan checks in our CI just to be safe. I'll update the JUnit version so a pull from upstream should get the CI running green. |
mikesamuel
reviewed
Dec 7, 2020
| * Change `.and` when combining two policies to respect explicit `skipIfEmpty` decisions. | ||
| * HTML entity decoding now follows HTML standard rules about when a semicolon is optional. | ||
| [Fixes #193](https://github.com/OWASP/java-html-sanitizer/issues/193) | ||
| * Fix table formatting [#137](https://github.com/OWASP/java-html-sanitizer/issues/137) |
There was a problem hiding this comment.
Most of the edits seem to be merge edits which makes this hard to review. Did you have a branch that was pointed at an older version? Can you reapply your patch to a new branch derived from HEAD?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #212