Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for 2.0 release and mobile app release and shorten the build time. #528

Merged
merged 2 commits into from
May 21, 2024
Merged

Prepare for 2.0 release and mobile app release and shorten the build time. #528

merged 2 commits into from
May 21, 2024

Conversation

sydseter
Copy link
Collaborator

Instead of building everything, let's just build what we need to build and test.

@sydseter sydseter requested a review from rewtd May 16, 2024 09:54
rewtd
rewtd requested changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@rewtd rewtd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should also remove the "dynamic" from the -all list for now?

@sydseter
Copy link
Collaborator Author

Yeah that's a good idea.

@sydseter sydseter force-pushed the prepare-for-release branch from 5b66704 to 04b2160 Compare May 20, 2024 17:05
@sydseter
Copy link
Collaborator Author

done!

@sydseter sydseter force-pushed the prepare-for-release branch from 04b2160 to 9652274 Compare May 20, 2024 17:06
github-actions bot added a commit that referenced this pull request May 20, 2024
@github-actions
Upload pr528-owasp_cornucopia_webapp_guide_en_1.22_dynamic.docx (c6d37)
8781267 
Pull request: #528
Commit: c6d370e
github-actions bot added a commit that referenced this pull request May 20, 2024
@github-actions
Upload pr528-owasp_cornucopia_webapp_cards_en_1.22_leaflet.idml (c6d37)
709a911 
Pull request: #528
Commit: c6d370e
github-actions bot added a commit that referenced this pull request May 20, 2024
@github-actions
Upload pr528-owasp_cornucopia_webapp_guide_en_1.22_static.docx (c6d37)
260d7be 
Pull request: #528
Commit: c6d370e
github-actions bot added a commit that referenced this pull request May 20, 2024
@github-actions
Upload pr528-owasp_cornucopia_webapp_cards_en_1.22_static.idml (c6d37)
47a6397 
Pull request: #528
Commit: c6d370e
github-actions bot added a commit that referenced this pull request May 20, 2024
@github-actions
Upload pr528-owasp_cornucopia_webapp_guide_es_1.22_static.docx (c6d37)
24859fe 
Pull request: #528
Commit: c6d370e
github-actions bot added a commit that referenced this pull request May 20, 2024
@github-actions
Upload pr528-owasp_cornucopia_webapp_guide_fr_1.22_static.docx (c6d37)
52ac682 
Pull request: #528
Commit: c6d370e
github-actions bot added a commit that referenced this pull request May 20, 2024
@github-actions
Upload pr528-owasp_cornucopia_webapp_guide_nl_1.22_static.docx (c6d37)
87b415e 
Pull request: #528
Commit: c6d370e
github-actions bot added a commit that referenced this pull request May 20, 2024
@github-actions
Upload pr528-owasp_cornucopia_webapp_guide_no-nb_1.22_static.docx (c6…
6ad753f 
…d37)

Pull request: #528
Commit: c6d370e
github-actions bot added a commit that referenced this pull request May 20, 2024
@github-actions
Upload pr528-owasp_cornucopia_webapp_guide_pt-br_1.22_static.docx (c6…
ecce739 
…d37)

Pull request: #528
Commit: c6d370e
github-actions bot added a commit that referenced this pull request May 20, 2024
@github-actions
Upload pr528-owasp_cornucopia_webapp_guide_en_2.00_dynamic.docx (c6d37)
22b050d 
Pull request: #528
Commit: c6d370e
github-actions bot added a commit that referenced this pull request May 20, 2024
@github-actions
Upload pr528-owasp_cornucopia_webapp_guide_en_2.00_static.docx (c6d37)
9530601 
Pull request: #528
Commit: c6d370e
github-actions bot added a commit that referenced this pull request May 20, 2024
@github-actions
Upload pr528-owasp_cornucopia_webapp_cards_en_2.00_leaflet.idml (c6d37)
603cbd4 
Pull request: #528
Commit: c6d370e
github-actions bot added a commit that referenced this pull request May 20, 2024
@github-actions
Upload pr528-owasp_cornucopia_webapp_cards_en_2.00_static.idml (c6d37)
35f1b8f 
Pull request: #528
Commit: c6d370e
github-actions bot added a commit that referenced this pull request May 20, 2024
@github-actions
Upload pr528-owasp_cornucopia_webapp_guide_es_2.00_static.docx (c6d37)
656f738 
Pull request: #528
Commit: c6d370e
github-actions bot added a commit that referenced this pull request May 20, 2024
@github-actions
Upload pr528-owasp_cornucopia_webapp_guide_fr_2.00_static.docx (c6d37)
ea2509e 
Pull request: #528
Commit: c6d370e
github-actions bot added a commit that referenced this pull request May 20, 2024
@github-actions
Upload pr528-owasp_cornucopia_webapp_guide_nl_2.00_static.docx (c6d37)
5fdc007 
Pull request: #528
Commit: c6d370e
github-actions bot added a commit that referenced this pull request May 20, 2024
@github-actions
Upload pr528-owasp_cornucopia_webapp_guide_no-nb_2.00_static.docx (c6…
520a10e 
…d37)

Pull request: #528
Commit: c6d370e
github-actions bot added a commit that referenced this pull request May 20, 2024
@github-actions
Upload pr528-owasp_cornucopia_webapp_guide_pt-br_2.00_static.docx (c6…
82beb19 
…d37)

Pull request: #528
Commit: c6d370e
github-actions bot added a commit that referenced this pull request May 20, 2024
@github-actions
Upload pr528-owasp_cornucopia_mobileapp_cards_en_1.00_static.idml (c6…
0e5563f 
…d37)

Pull request: #528
Commit: c6d370e
@github-actions GitHub Actions
Copy link
Contributor

🤖 Pull request artifacts

The generated Cornucopia cards in this pull request.

file commit
owasp_cornucopia_webapp_guide_en_1.22_dynamic.docx c6d370e
owasp_cornucopia_webapp_cards_en_1.22_leaflet.idml c6d370e
owasp_cornucopia_webapp_guide_en_1.22_static.docx c6d370e
owasp_cornucopia_webapp_cards_en_1.22_static.idml c6d370e
owasp_cornucopia_webapp_guide_es_1.22_static.docx c6d370e
owasp_cornucopia_webapp_guide_fr_1.22_static.docx c6d370e
owasp_cornucopia_webapp_guide_nl_1.22_static.docx c6d370e
owasp_cornucopia_webapp_guide_no-nb_1.22_static.docx c6d370e
owasp_cornucopia_webapp_guide_pt-br_1.22_static.docx c6d370e
owasp_cornucopia_webapp_guide_en_2.00_dynamic.docx c6d370e
owasp_cornucopia_webapp_guide_en_2.00_static.docx c6d370e
owasp_cornucopia_webapp_cards_en_2.00_leaflet.idml c6d370e
owasp_cornucopia_webapp_cards_en_2.00_static.idml c6d370e
owasp_cornucopia_webapp_guide_es_2.00_static.docx c6d370e
owasp_cornucopia_webapp_guide_fr_2.00_static.docx c6d370e
owasp_cornucopia_webapp_guide_nl_2.00_static.docx c6d370e
owasp_cornucopia_webapp_guide_no-nb_2.00_static.docx c6d370e
owasp_cornucopia_webapp_guide_pt-br_2.00_static.docx c6d370e
owasp_cornucopia_mobileapp_cards_en_1.00_static.idml c6d370e
owasp_cornucopia_mobileapp_cards_en_1.00_leaflet.idml c6d370e

github-actions bot added a commit that referenced this pull request May 20, 2024
@github-actions
Upload pr528-owasp_cornucopia_mobileapp_cards_en_1.00_leaflet.idml (c…
d2ce1df 
…6d37)

Pull request: #528
Commit: c6d370e
@sydseter sydseter requested a review from rewtd May 20, 2024 17:52
rewtd
rewtd approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@rewtd rewtd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we do need copi up on owasp.org for this to work however...

@sydseter sydseter merged commit 73daec8 into master May 21, 2024
14 checks passed
@sydseter sydseter deleted the prepare-for-release branch May 21, 2024 08:30
@sydseter
Copy link
Collaborator Author

@rewtd This may not be the right way to generate the qr codes. They need to be embedded into the idml and docx files and indesign already have a way of generating qr codes. I am wondering whether we should remove it.

@rewtd
Copy link
Collaborator

rewtd commented May 21, 2024 via email

sydseter added a commit to sydseter/cornucopia that referenced this pull request Jun 7, 2024
@sydseter
Merge pull request OWASP#528 from OWASP/prepare-for-release
b77107f 
Prepare for 2.0 release and mobile app release and shorten the build time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rewtd rewtd rewtd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sydseter @rewtd