-
-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend website #538
base: master
Are you sure you want to change the base?
Extend website #538
Conversation
To test locally: # Ensure Python 3
make install-python-requirements
make serve
# open http://localhost:8000/ |
I added as well a Github Action that builds and checks for dead links at every commit and on every pull request. |
Fixed all the conflicts again. Are there any plans @vanderaj to get this PR merged? |
@mackowski hello, sorry to ping you. I really think this PR brings in needed and useful contributions, maybe you can manage to unlock it. Or at least give me some feedback. |
hey @Naramsim I was on a trip without access to the internet. Yes I see that your changes are great. |
Hi Alessandro (@Naramsim), So I found your PR. Thank you very much, it looks very useful.
Thank you and cheers |
Hi @sslHello,
|
Also note that the label with name automatization, could be renamed to the more common word automation. |
Update on your 2nd point. Maybe I understand what you mean. Do you want a way to automatically generate the website, without generating it on your machine and deploying it manually? Well, this PR does exactly this. Whenever a PR will be merged in the |
@sslHello, did you have time to review what I wrote? |
Hi @Naramsim,
Thank you! |
Hi!
|
One thing that can be made to finally include this PR in the source code is disabling the CI, so you won't have any automated deployments but we will have all the other changes. |
Let me know if I need to comment it out |
Hi, @sslHello I came back here to see how the repo evolved. This PR can still be merged |
This PR finalizes the skeleton for the Top10 website.
A live copy can be found at my repo: https://naramsim.github.io/Top10/
It also brings in a Github Action that builds and deploys (at every commit) the website on Github Pages.
@vanderaj and @mackowski, do you need a brief explanation of how everything works? Or will you understand it by looking at the files?