Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changes proposed in this pull request
I started my work on this PR to address #633. The next step implementation was getting the Nettacker its own PyPI package. So far trusted publish management has been configured for my personal account for both PyPI and Test PyPI platforms. So now the package can be installed using
pip install nettacker
command (the current version is 0.3.1alpha). The docker image build process has been adjusted to use the published package.As a part of poetry setup I moved source code to
src/nettacker
directory (this is why 750 files are shown as changed). The number of actually changed files is way smaller and they mostly include the following changes:src/nettacker
project structureI added pytest support and fixed existing tests:
top_1000_common_passwords
test to check the password for uniquenessunittest::assertDictEqual
method which doesn't check for dict keys order)select_maximum_cpu_core
test has been changed to use a mock (it was failing on the GH when I ran it first), and the method itself has been refactored a bitThe next steps: