Update Docker configuration files #748
Conversation
- Use heredocs format for RUN command - Add minor readability improvements
|
This is not backwardly-compatible with Docker v20.10 as it fails with error:
It works in Docker v23.0, however the saving on the image provided by this PR is minimal, so I am not going to merge it just yet |
- Remove heredocs, use `&& \` for chaining - Add Docker build tests for 24.0, 23.0, and 20.10 versions - Add `build-docker-image` as a requirement for the `test` job - Add missing apt-utils - Set apt DEBIAN_FRONTEND to noninteractive - Add image cleanup instructions
Well, that makes sense. I'm surprised it worked at all as heredocs requires buiildkit/buildx. I've changed that part and added a sort of smoke tests for multiple docker engine versions -- 24.0, 23.0, and 20.10 (I guess that's what you were doing manually). It just checks whether the image is buildable. This job is required to be successful for running PTAL when you have a chance. |
| RUN mkdir -p .data/results && \ | ||
| apt-get update && \ | ||
| apt-get install -y $(cat requirements-apt-get.txt) && \ | ||
| pip3 install --upgrade pip && \ | ||
| pip3 install -r requirements.txt && \ | ||
| pip3 install -r requirements-dev.txt && \ | ||
| apt-get clean && \ | ||
| rm -rf /root/.cache/* && \ | ||
| rm -rf /var/lib/apt/lists/* |
There was a problem hiding this comment.
I am not sure if that's a good idea, it makes it harder to debug for each step if fails, and more time consuming to repeat the process.
|
Suppressed by #894 |
Checklist
Changes proposed in this pull request
Update Docker configuration files to minimize the layers amount and make the code more readable.
upd:
The initial heredocs approach was replaced with RUN commands chained with
&& \due to the unsatisfied buildkit requirements. I added missingapt-utilspackage to resolvedebconf: delaying package configuration, since apt-utils is not installedand set DEBIAN_FRONTEND to noninteractive. Also added a couple of cleanup instructions to minimize the image size.