Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update 12.3.3 CWE mapping from CWE-98 to CWE-73 #1776

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

hazanasec
Copy link
Contributor

Update the mapping of the ASVS requirement 12.3.3. The current mapping is to CWE-98, which is specific to PHP's "Include/Require" statements. The proposed change is to map it to CWE-73, which is a more generalized weakness that accurately describes the problem of allowing user-submitted input to control or influence file paths or names in filesystem operations. This more inclusive mapping covers a broader range of technologies and scenarios, making it a more suitable choice.

@tghosth
Copy link
Collaborator

tghosth commented Nov 1, 2023

Seems good to me, @elarlang any objections?

@elarlang
Copy link
Collaborator

elarlang commented Nov 1, 2023

I agree to make the change as it does not change anything meaninful (as we most likely going to drop CWE mapping - #1481). I also don't think this requirement survives the same way to v5.0.

We have related issues opened for the topic (#1470, #1427).

Usual process: we open issues for having discussion and agreement for the proposed change and if we have agreement, then we go for PR.

Ok, here the change is so small that issue-process may feel like overhead. On the other hand, this is the way we would like to keep overview and reasoning for the future.

@tghosth tghosth merged commit 6d6df35 into OWASP:master Nov 2, 2023
2 checks passed
@tghosth
Copy link
Collaborator

tghosth commented Nov 2, 2023

I think this is small enough and self-explanatory enough to make an exception but I agree we would usually prefer an issue first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants