Move 3.5.2 to 3.1.3 and modify to resolve #1522 #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sjord
reviewed
Oct 3, 2023
5.0/en/0x12-V3-Session-management.md
Outdated
| @@ -17,6 +17,7 @@ As previously noted, these requirements have been adapted to be a compliant subs | |||
| | :---: | :--- | :---: | :---: | :---: | :---: | :---: | | |||
| | **3.1.1** | [DELETED, MERGED TO 8.3.1] | | | | | | | |||
| | **3.1.2** | [ADDED] Verify that the application performs all session token verification using a trusted, back-end service. | ✓ | ✓ | ✓ | 603 | | | |||
| | **3.1.3** | [MOVED FROM 3.5.2, MODIFIED] Verify that the application uses either **cryptographically signed or opaque tokens** for session management. Static API secrets and keys should be avoided. | ✓ | ✓ | ✓ | 798 | 7.1 | | |||
There was a problem hiding this comment.
**cryptographically signed or opaque tokens**
I don't think it is a good idea to use markdown in the table. It messes with CSV export, for example. Also, I don't think the emphasis adds anything here.
There was a problem hiding this comment.
Great point @Sjord! I have removed that
|
3.5.2 was level 2 is the change intended? |
|
Yes since this is now a more general/basic requirement it should be level 1 @elarlang |
elarlang
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request relates to issue #1522