Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 - Move and update 3.2.5 #2368

Closed
ryarmst opened this issue Nov 11, 2024 · 7 comments · Fixed by #2373
Closed

V3 - Move and update 3.2.5 #2368

ryarmst opened this issue Nov 11, 2024 · 7 comments · Fixed by #2373
Labels
1) Discussion ongoing Issue is opened and assigned but no clear proposal yet 6) PR awaiting review V3 _5.0 - prep This needs to be addressed to prepare 5.0

Comments

@ryarmst
Copy link
Collaborator

ryarmst commented Nov 11, 2024

At present, 3.2.5 is intended to prevent the forced creation of application sessions as could occur through an unintended interaction with an SSO system. As such, it is probably more appropriate in V3.6. I also think the wording could use an update. Ping @elarlang

Original (V3.2 Session Binding)

# Description L1 L2 L3 CWE NIST §
3.2.5 [ADDED] Verify that creating a session for the application requires the user's consent and that the application is protected against a CSRF-style attack where a new application session for the user is created via SSO without user interaction.

Proposed (V3.6 Federated Re-authentication)

# Description L1 L2 L3 CWE NIST §
3.6.3 [ADDED] Verify that creation of a session requires either the user's consent or an explicit action, preventing the creation of new application sessions without user interaction.

Related discussion in #2120.

@elarlang
Copy link
Collaborator

elarlang commented Nov 12, 2024

Moving requirement was proposed and agreed during the summit.

Requirement text rises some questions - why to use "or"? I think it is not "consent" or "action"? How you can achieve a consent without an action?

I would use "and" or "by".

@elarlang elarlang added 1) Discussion ongoing Issue is opened and assigned but no clear proposal yet _5.0 - prep This needs to be addressed to prepare 5.0 V3 labels Nov 12, 2024
@ryarmst
Copy link
Collaborator Author

ryarmst commented Nov 12, 2024

Consent may have specific meaning in certain contexts whereas an "action" may not satisfy consent, but nevertheless conveys the user's intent (and presence). I would also be happy reformulating it to remove "consent" as in the following:

Verify that creation of a session requires the user's presence and intent, preventing the creation of new application sessions without user interaction.

@elarlang elarlang added the 4) proposal for review Issue contains clear proposal for add/change something label Nov 12, 2024
@elarlang
Copy link
Collaborator

user presence

This is debatable - is user presence achieved if user's browser is visiting some URL? But without user noticing it.

I would also be happy reformulating it to remove "consent"

I would keep it in. Consent here is the abstract goal to achieve - the user knows that the application creates a new session for the user.

I'm not happy about the wording from initial proposal, but I also don't know how to improve it, so I propose to go with this one:

Verify that creation of a session requires either the user's consent or an explicit action, preventing the creation of new application sessions without user interaction.

@ryarmst
Copy link
Collaborator Author

ryarmst commented Nov 13, 2024

This is debatable - is user presence achieved if user's browser is visiting some URL? But without user noticing it.

I would say that presence is achieved in that scenario and that the logical and with intent indicates that presence alone is not sufficient, but I think either wording probably sufficiently conveys the intended outcome of the requirement.

@elarlang
Copy link
Collaborator

User browser visiting the application != user presence.

User intent is something we can not verify from the application.

So it is user-interaction needed to verify the user consent.

@ryarmst
Copy link
Collaborator Author

ryarmst commented Nov 13, 2024

Alright, so the initial proposal is fine for now then?

Verify that creation of a session requires either the user's consent or an explicit action, preventing the creation of new application sessions without user interaction.

I can make a PR.

@elarlang elarlang mentioned this issue Nov 13, 2024
@elarlang elarlang added 6) PR awaiting review and removed 4) proposal for review Issue contains clear proposal for add/change something labels Nov 13, 2024
@elarlang
Copy link
Collaborator

I can make a PR.

I included it into #2373

@elarlang elarlang linked a pull request Nov 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1) Discussion ongoing Issue is opened and assigned but no clear proposal yet 6) PR awaiting review V3 _5.0 - prep This needs to be addressed to prepare 5.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants