Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the Cryptography Appendix for MAC, signatures, key derivation functions #2314

Closed
randomstuff opened this issue Nov 7, 2024 · 4 comments
Assignees
Labels
1) Discussion ongoing Issue is opened and assigned but no clear proposal yet AppendixV Appendix with crypto details enhancement _5.0 - Not blocker This issue does not block 5.0 so if it gets addressed then great, if not then fine.

Comments

@randomstuff
Copy link
Contributor

The crypto appendix currently provides guidance around suitable algorithms for:

  • ciphers
  • random generation
  • symmetric ciphers
  • key wrapping
  • key exchange and DH groups
  • secure hash functions
  • password hashing

The following things are not covered:

  • MAC
  • digital signatures
  • key derivation functions

Should this appendix be expanded to cover these (and relevant requirements be included as well)?

@danielcuthbert
Copy link
Collaborator

Indeed this is needed, I'll add it to the roadmap. The good thing about moving all the deeper technical stuff into an appendix is that we aren't as constrained as we are with the main chapters, so this is much easier. Ill assign this to me for now

@tghosth tghosth added 1) Discussion ongoing Issue is opened and assigned but no clear proposal yet _5.0 - prep This needs to be addressed to prepare 5.0 _5.0 - Not blocker This issue does not block 5.0 so if it gets addressed then great, if not then fine. AppendixV Appendix with crypto details and removed _5.0 - prep This needs to be addressed to prepare 5.0 V6 labels Nov 7, 2024
danielcuthbert added a commit that referenced this issue Nov 11, 2024
@danielcuthbert
Copy link
Collaborator

Morning, spent last night adding this into a patch https://github.com/OWASP/ASVS/blob/dc_v6_patch3/5.0/en/0x97-Appendix-V_Cryptography.md

Does this match what you had in mind @randomstuff

@randomstuff
Copy link
Contributor Author

randomstuff commented Nov 11, 2024

In the KDF section, we might want to add the PRF used in TLS 1.2 (for compatibility with TLS 1.2) (?).

@danielcuthbert
Copy link
Collaborator

added in #2371

tghosth pushed a commit that referenced this issue Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1) Discussion ongoing Issue is opened and assigned but no clear proposal yet AppendixV Appendix with crypto details enhancement _5.0 - Not blocker This issue does not block 5.0 so if it gets addressed then great, if not then fine.
Projects
None yet
Development

No branches or pull requests

3 participants