Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Positive Technologies Application Inspector (PT AI) SARIF report support #123

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

ZhukovAN
Copy link
Contributor

PT AI SARIF report support added

@darkspirit510
Copy link
Contributor

Hi @ZhukovAN,
thank you for the contribution. The code looks good, nothing to complain from my side. Just one thing - could you provide a complete result file to either me ([email protected]) or @davewichers ([email protected]) so we can verify everything works as expected? Don't worry, the file obviously won't be published anywhere!
Sascha

@ZhukovAN
Copy link
Contributor Author

Hi! Sure, check your mail boxes

@darkspirit510
Copy link
Contributor

Hi @ZhukovAN,
thank you for the file! It can be read without errors. But I have a minor issue. Could you abbreviate the display name? Positive Technologies Application Inspector underflows the percentage and version number, it's hard to read in the toolresults_comparison.png file.
Sascha

@ZhukovAN
Copy link
Contributor Author

Does "PT Application Inspector" fits flawlessly?

@ZhukovAN
Copy link
Contributor Author

ZhukovAN commented Nov 7, 2024

Hi! I've shortened tool name and also removed build number from version info to make it shorter. I think now benchmark comparison chart looks perfect :)

@darkspirit510
Copy link
Contributor

Hi @ZhukovAN,
looks good to me! @davewichers this can be merged, if you agree.

PS: @ZhukovAN be careful when posting results of commercial tools (unless you have been authorized to do so 😉)
Sascha

@davewichers davewichers merged commit 4b45149 into OWASP-Benchmark:main Nov 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants