Fix memory leak in EventJetVarProducer, fix fiducial maps in 2022 #50
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borzari
reviewed
Sep 10, 2024
| @@ -249,7 +248,6 @@ def customize (process, | |||
| process.TriggerWeightProducer.target = cms.string ("") | |||
| process.TriggerWeightProducer.produceMetLeg = cms.bool(False) | |||
| process.TriggerWeightProducer.produceTrackLeg = cms.bool(False) | |||
| process.TriggerWeightProducer.produceGrandOr = cms.bool(False) | |||
There was a problem hiding this comment.
Github is marking this as removed, but I assume you just changed it to True, right? At least, when I open the file here https://github.com/OSU-CMS/DisappTrks/blob/be74e188e9512d1e1f0eb1929400af5bac113651/StandardAnalysis/python/customize.py, it is what I see. Or you just didn't change it and github is marking things for some reason.
There was a problem hiding this comment.
yeah not sure why it is marking this line from what I can see it wasn't changed and I never meant to change it
There was a problem hiding this comment.
Alright. Everything is fine, then
borzari
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delete jet veto map histograms after us to save memory
fix fiducial map in customize.py for 2022