chromium: Update to 132.0.6834.83 #867
Conversation
|
@MaxIhlenfeldt here's the initial PR for chromium 132 release. Please review :-) Note that there's a TODO section, where I might need your help if possible. |
There was a problem hiding this comment.
I haven't reviewed everything yet, but I've left a few comments already.
Regarding the mentioned TODOs:
- you can use this repo's
generate_license_list.pyscript to generate the updated license hashes. - Why do we need to set
"RUST_CHANNEL = "nightly"? And where would one need to set that?
meta-chromium/recipes-browser/chromium/files/0009-Adjust-the-Rust-build-to-our-needs.patch
Outdated
Show resolved
Hide resolved
...mium/recipes-browser/chromium/files/0001-Drop-GN-compiler-settings-conflicting-with-OE.patch
Outdated
Show resolved
Hide resolved
meta-chromium/recipes-browser/chromium/chromium-ozone-wayland_132.0.6834.83.bb
Show resolved
Hide resolved
adalessandro
force-pushed
the
wip/adalessandro/update-stable-132
branch
from
f960f69 to
f4a919b
Compare
|
I am trying to build for the i.MX6 cpu and get the following. 80/54278] arm-pmc-linux-gnueabi-clang++ -target arm-pmc-linux-gnueabi -mfpu=neon -mfloat-abi=hard -mcpu=cortex-a9 -mlittle-endian --dyld-prefix=/usr -Qunused-arguments -fstack-protector-strong -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wforma |
@san-skov-dk could you please retry by pulling the latest changes from this MR? |
Release notes:
https://chromereleases.googleblog.com/2025/01/stable-channel-update-for-desktop_14.html
Signed-off-by: Ariel D'Alessandro <[email protected]>
Regenerated by running `generate_license_list.py` script. Signed-off-by: Ariel D'Alessandro <[email protected]>
This commit rebase previous patches for chromium 132.0.6834.83. Signed-off-by: Ariel D'Alessandro <[email protected]>
A new assertion has been introduced, causing the build to fail with this option enabled: | ERROR at //build/config/linux/libdrm/BUILD.gn:18:3: Assertion failed. | assert(!is_linux, "System libdrm is not supported in linux") | ^----- | System libdrm is not supported in linux | See //ui/gfx/BUILD.gn:666:15: which caused the file to be included. | deps += [ "//build/config/linux/libdrm" ] Link: https://chromium-review.googlesource.com/c/chromium/src/+/5956068 Signed-off-by: Ariel D'Alessandro <[email protected]>
adalessandro
force-pushed
the
wip/adalessandro/update-stable-132
branch
from
f4a919b to
9e5ee27
Compare
|
@san-skov-dk could you please retry by pulling the latest changes from this MR? In any case, more context on your build setup would be great for me to peek/reproduce/help with it. Thanks! Still looking into the same issue [submodule "meta-oe"] If you need more info I will be happy to provide it. |
I've hit the same issue cross-compilting for @MaxIhlenfeldt looks like it's an old issue that had been work-around previously: #827 (comment) . Sounds familiar? I'll check this out anyway. |
|
Indeed, this is pretty similar to @san-skov-dk @MaxIhlenfeldt let me know if you get the chance to test this out :-) |
adalessandro
force-pushed
the
wip/adalessandro/update-stable-132
branch
from
26d3dd9 to
00ee3b6
Compare
FYI there's a pipeline running here for different targets https://gitlab.collabora.com/mediatek/aiot/bsp/manifest/-/pipelines/126047 |
|
@san-skov-dk @MaxIhlenfeldt let me know if you get the chance to test this out :-) It is building now :) |
|
@MaxIhlenfeldt could you do a full PR review? |
...romium/recipes-browser/chromium/files/0013-build-config-compiler-BUILD.gn-Disable-CREL.patch
Outdated
Show resolved
Hide resolved
...cipes-browser/chromium/files/0014-Revert-Set-Rust-symbol-visibility-to-hidden-when-C-s.patch
Outdated
Show resolved
Hide resolved
...cipes-browser/chromium/files/0015-pdfium-Fix-missing-PDFiumAPIStringBufferAdapter-temp.patch
Outdated
Show resolved
Hide resolved
...cipes-browser/chromium/files/0014-Revert-Set-Rust-symbol-visibility-to-hidden-when-C-s.patch
Outdated
Show resolved
Hide resolved
...cipes-browser/chromium/files/0015-pdfium-Fix-missing-PDFiumAPIStringBufferAdapter-temp.patch
Outdated
Show resolved
Hide resolved
...cipes-browser/chromium/files/0016-Revert-Connect-the-Rust-log-crate-to-the-base-loggin.patch
Outdated
Show resolved
Hide resolved
This feature is not supported on the current clang toolchain version, which causes build to fail with the following error: | clang++: error: unsupported argument '--crel' to option '-Wa,' | clang++: error: unsupported argument '--allow-experimental-crel' to option '-Wa,' Signed-off-by: Ariel D'Alessandro <[email protected]>
adalessandro
force-pushed
the
wip/adalessandro/update-stable-132
branch
3 times, most recently
from
d3c93cc to
7b49f62
Compare
This reverts chromium commit ee3900fd57b3c580aefff15c64052904d81b7760. * Change-Id: https://crrev.com/c/5966273 Fixes the following compilation error: ``` | FAILED: obj/third_party/rust/ryu/v1/lib/libryu_lib.rlib [...] | error: unknown unstable option: `default-visibility` ``` This patch will be dropped once Rust >= 1.83 is available, which includes: * rust-lang/rust#130005 [0] * rust-lang/rust#131519 [1] Note that currently meta-lts-mixins [2] provides the following versions: * kirkstone: `1.80.1` * scarthgap: `1.81.0` [0] rust-lang/rust#130005 [1] rust-lang/rust#131519 [2] https://git.yoctoproject.org/meta-lts-mixins Signed-off-by: Ariel D'Alessandro <[email protected]>
adalessandro
force-pushed
the
wip/adalessandro/update-stable-132
branch
from
7b49f62 to
1f12168
Compare
I think I started doing that ages ago just to make it easier for people actually using the recipe and having to do their due diligence with Chromium's ton of license files and mixes. If it's too much work I think we shouldn't block on this. |
|
I wonder if @SoumyaWind would like to do some testing too? |
Thanks for the context! I personally think the list of changed licenses should be enough. If people were relying on the links to the CLs they'll complain, and we can bring them back :) |
Fix the following compilation error: ``` | ../../pdf/pdfium/pdfium_api_wrappers.cc:150:32: error: alias template 'PDFiumAPIStringBufferAdapter' requires template arguments; argument deduction only allowed for class templates | 150 | PDFiumAPIStringBufferAdapter adapter(&name, expected_size, | | ^ | ../../pdf/pdfium/pdfium_api_string_buffer_adapter.h:173:1: note: template is declared here | 173 | using PDFiumAPIStringBufferAdapter = | | ^ | 1 error generated. ``` This patch will be dropped once clang >= 19.1.0 is available, which includes support for class template argument deduction (CTAD) for type alias templates (P1814R0 [0]) (#54051 [1]). Note that currently meta-clang [2] provides the clang version `18.1.6`. [0] https://wg21.link/p1814r0 [1] llvm/llvm-project#54051 [2] https://github.com/kraj/meta-clang Signed-off-by: Ariel D'Alessandro <[email protected]>
This reverts chromium commit 7ea0a5e831dd5 ("Connect the Rust log crate
to the //base logging implementation".
The above commit enabled bindgen for the Rust logger. Similar to patch
0011-Disable-crabbyavif-to-fix-build-errors.patch added in commit [0],
this fixes a build error that's most likely because the way upstream
configures bindgen makes it incompatible with our cross-architecture
builds.
```
| FAILED: gen/base/logging_rust_log_integration_bindgen_generator/bindings.rs
| [...]
| panicked at bindgen-cli/main.rs:52:36:
| Unable to generate bindings: ClangDiagnostic("error: unsupported option '-mbranch-protection=' for target 'x86_64-unknown-linux-gnu'\n")
```
[0] meta-browser commit fd347dc ("chromium: Update to 127.0.6533.99")
Signed-off-by: Ariel D'Alessandro <[email protected]>
adalessandro
force-pushed
the
wip/adalessandro/update-stable-132
branch
from
1f12168 to
cf79385
Compare
@MaxIhlenfeldt shoud I squash all the commits and have a single "update" commit as 0dad36d ? Then add the respective details about patch and license changes? |
|
@rakuco Sure, I'll start testing and update once I'm done. |
I think it's enough if you edit the PR description to add the list of added, removed, and updated licenses (no need to link to the CLs introducing these license changes for now I'd say). Then I can let GitHub automatically squash all the commits when merging the PR. |
Release notes:
Build and patch changes:
Dropped
None
Added
Test-built:
Recipes:
chromium-x11chromium-ozone-waylandTarget machines:
qemuarmqemuarm64qemux86-64Releases:
Layers:
Reference pipeline: