Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up convert module functions into classes #22

Merged
merged 21 commits into from
Feb 8, 2019
Merged

Tidy up convert module functions into classes #22

merged 21 commits into from
Feb 8, 2019

Conversation

leewujung
Copy link
Member

  • converted content of set_nc_groups.py to class SetGroups
  • converted EK60 conversion code into class ConvertEK60
  • added test function under convert module

@leewujung
converted content of set_nc_groups.py to a class
1c27cf0
@leewujung
updated environment.yml
95a9d80
@leewujung
changed ek60.py to use SetGroups class when saving to .nc
cc6be6b
@leewujung
revised docstrings in ek60.py and revised requirements.txt
d9db04a
@leewujung
created tests under convert/
0456fb2
@leewujung
save_raw_to_nc() overhaul, grouped params under Beam group for readab…
ca68581 
…ility
@leewujung
updated set_nc_groups.py to work with new ek60.save_raw_to_nc()
253837d
@leewujung
updated SetGroups.set_beam() to check EK60-specific params before saving
5705e3c
@leewujung
added test_convert.py to test EK60 raw unpacking, currently only test…
433d0d5 
… backscatter_r under Beam group
@leewujung
added -rrequirements.txt to tox testenv deps
ab3b0d8
@leewujung
added xarray into version.py requires
f5f0ecf
@leewujung
added EK60 test data
7d1386e
@leewujung
added first shot of echopype model and process.calibrate
8cc76d4
@leewujung
very minor change in ek60.save_raw_to_nc() to increase readability
50e2b43
@leewujung
tested using decorator
31b11f0
@leewujung
revised __init__.py
b4d1bc0
@leewujung
merge basic-fcn branch back to master
45266ab
@leewujung
fixed missing info in version.py
4b52dfa
@leewujung
wrapped everything under ek60.py into a ConvertEK60.py class
0245abf
@leewujung
updated test_convert.py to use ConvertEK60 class
e3c937c
@leewujung
Merge remote-tracking branch 'upstream/master'
fce28f5
@leewujung leewujung changed the title Tidy up convert model functions into classes Tidy up convert module functions into classes Feb 8, 2019
@leewujung leewujung merged commit 2255df1 into OSOceanAcoustics:master Feb 8, 2019
This was referenced Feb 8, 2019
Closed
Closed
lsetiawan pushed a commit to lsetiawan/echopype that referenced this pull request May 13, 2020
@leewujung
Merge pull request OSOceanAcoustics#22 from leewujung/master
78087bf 
Tidy up convert module functions into classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@leewujung