Updated paths in test_align_to_ping_time_glider_azfp to use pytest fixture #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oftfrfbf
changed the title
|
@oftfrfbf : Thanks for catching this bug and the PR! Sorry it took me forever to get to this. Everything looks great, and I'll merge this now! |
leewujung
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first time commiting so I hope I am following all the right procedures.
I noticed a broken test here:
echopype/echopype/tests/utils/test_align.py
Line 239 in 249952c
The file paths were not using the pytest.fixture and so the "xmlmap.root" value was ending up referenced as:
'/Users/user/Documents/github/echopype/echopype/tests/utils/echopype/test_data/azfp/rutgers_glider_external_nc/18011107.XML'
when it should be:
'/Users/user/Documents/github/echopype/echopype/test_data/azfp/rutgers_glider_external_nc/18011107.XML'
Please let me know if this isn't correct. Regards.