-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip Parsing Invalid EK80 Environment Datagram(s) #1387
Skip Parsing Invalid EK80 Environment Datagram(s) #1387
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1387 +/- ##
==========================================
- Coverage 83.52% 80.22% -3.31%
==========================================
Files 64 18 -46
Lines 5686 3089 -2597
==========================================
- Hits 4749 2478 -2271
+ Misses 937 611 -326
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@leewujung This should be ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested some text for comments. Other than that, I think we can merge this.
Co-authored-by: Wu-Jung Lee <[email protected]>
@leewujung Thanks for the review! And yeah you're right, it's not a bug per se. I just added your suggestion. |
Temporary fix for #1386