-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow external arrays in add depth; Add universal ping time alignment function #1369
Allow external arrays in add depth; Add universal ping time alignment function #1369
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1369 +/- ##
==========================================
- Coverage 83.52% 78.34% -5.18%
==========================================
Files 64 27 -37
Lines 5686 2069 -3617
==========================================
- Hits 4749 1621 -3128
+ Misses 937 448 -489
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…NaNs in harmonize env param times
@leewujung This should be ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ctuguinay : Thanks for the changes! Other than some minor wording/capitalization things and small questions, I think this is good to go!
Co-authored-by: Wu-Jung Lee <[email protected]>
Co-authored-by: Wu-Jung Lee <[email protected]>
Co-authored-by: Wu-Jung Lee <[email protected]>
Co-authored-by: Wu-Jung Lee <[email protected]>
@leewujung Thanks for the review! This should be ready for a quick lookover again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! This is ready to be merged now.
Addresses #1368 and #1367.
Also, addresses #1332 since this was also related to the AZFP Glider notebook.