Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow external arrays in add depth; Add universal ping time alignment function #1369

Merged

Conversation

ctuguinay
Copy link
Collaborator

@ctuguinay ctuguinay commented Jul 25, 2024

Addresses #1368 and #1367.

Also, addresses #1332 since this was also related to the AZFP Glider notebook.

@ctuguinay ctuguinay modified the milestones: v0.9.1, v0.9.0 Jul 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.34%. Comparing base (9f56124) to head (c75592a).
Report is 133 commits behind head on main.

Files Patch % Lines
echopype/consolidate/api.py 81.25% 3 Missing ⚠️
echopype/utils/align.py 72.72% 3 Missing ⚠️
echopype/consolidate/ek_depth_utils.py 66.66% 1 Missing ⚠️
echopype/consolidate/loc_utils.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1369      +/-   ##
==========================================
- Coverage   83.52%   78.34%   -5.18%     
==========================================
  Files          64       27      -37     
  Lines        5686     2069    -3617     
==========================================
- Hits         4749     1621    -3128     
+ Misses        937      448     -489     
Flag Coverage Δ
unittests 78.34% <77.77%> (-5.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctuguinay ctuguinay changed the title Allow external arrays in add depth Allow external arrays in add depth; Add universal ping time alignment function Jul 26, 2024
@ctuguinay ctuguinay marked this pull request as ready for review July 29, 2024 18:59
@ctuguinay ctuguinay requested a review from leewujung July 29, 2024 18:59
@ctuguinay
Copy link
Collaborator Author

@leewujung This should be ready for review

@ctuguinay ctuguinay linked an issue Jul 30, 2024 that may be closed by this pull request
echopype/utils/align.py Outdated Show resolved Hide resolved
echopype/utils/align.py Outdated Show resolved Hide resolved
leewujung
leewujung previously approved these changes Aug 7, 2024
Copy link
Member

@leewujung leewujung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ctuguinay : Thanks for the changes! Other than some minor wording/capitalization things and small questions, I think this is good to go!

@ctuguinay
Copy link
Collaborator Author

@leewujung Thanks for the review! This should be ready for a quick lookover again.

@ctuguinay ctuguinay requested a review from leewujung August 7, 2024 22:26
Copy link
Member

@leewujung leewujung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! This is ready to be merged now.

@ctuguinay ctuguinay merged commit 9fd00d2 into OSOceanAcoustics:main Aug 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
3 participants