Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data type check for padding short complex pings #1353

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

ctuguinay
Copy link
Collaborator

@ctuguinay ctuguinay commented Jul 9, 2024

When testing SWFSC RAW files, there was a file where range was adaptive and based on bottom. When open_raw is called, these pings need to be padded because they are short and non-uniform with the other short pings. In this padding code, there was a snippet that relied on complex_ to work, but complex_ is complex128, while our data is complex64. I changed this to instead use complex64.

@ctuguinay ctuguinay added the bug Something isn't working label Jul 9, 2024
@ctuguinay ctuguinay added this to the v0.9.0 milestone Jul 9, 2024
@ctuguinay ctuguinay self-assigned this Jul 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.81%. Comparing base (9f56124) to head (26ecb36).
Report is 119 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1353      +/-   ##
==========================================
- Coverage   83.52%   78.81%   -4.71%     
==========================================
  Files          64       16      -48     
  Lines        5686     2700    -2986     
==========================================
- Hits         4749     2128    -2621     
+ Misses        937      572     -365     
Flag Coverage Δ
unittests 78.81% <100.00%> (-4.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@leewujung leewujung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ctuguinay for the diagnosis and quick fix!

@ctuguinay ctuguinay merged commit a2a98b6 into OSOceanAcoustics:main Jul 11, 2024
5 checks passed
@leewujung leewujung changed the title Padding Short Pings Fix data type check for padding short complex pings Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants