-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added parser support for EK80 MRU1 #1242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@praneethratna : Thanks for putting this in! I just have a minor comment about adding MRU1 in the docstring. I verified that the rest of open_raw
runs through fine with the pitch, roll, heave data stored in the Platform group as pitch, roll, and vertical_offset.
But the parsed heading
variable is not stored. Let me take a look at the convention to see if there's a variable we can store it, and if not, we can put it in the Platform group just with heading
as the name. I will get back to you on this!
It'll be nice to have a test file in the CI for this.
@jmjech: Do you have a file that is smaller (say a few MB) that we can use as a test file? It adds to the time for tests to run through if the test files are large, so we usually try to include only small files.
Thanks both!
I e-mailed a 2 MB file to Wu-Jung. Let me know if it works for you. I have other "smaller" files. |
5128d98
to
db52748
Compare
@jmjech: Thank you! The file works and does contain MRU1 datagrams. @praneethratna: I have added this file ( np.all(echodata["Platform"]["pitch"].data == np.array(parser.mru["pitch"]))
np.all(echodata["Platform"]["roll"].data == np.array(parser.mru["roll"]))
np.all(echodata["Platform"]["vertical_offset"].data == np.array(parser.mru["heave"])) # note variable name change Would be good to have these in the tests, by using the parser object echopype/echopype/convert/api.py Line 423 in 03e3b52
Thanks!! |
Also, on storing the @praneethratna: Could you please add this to the set group so that it gets stored together with the other variables? As you have seen, they are on the same timebase since they are all from the MRU* datagrams. Make sure to add the attributes listed. Thanks! |
@leewujung I have added docstring for new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@praneethratna : Thanks for adding heading
and test. I'll merge this now. :)
Thanks! |
Addresses #1239 and now EK80 files of type MRU version 1 can be parsed.
CC @leewujung