Fixed reshape bug in pad_shorter_ping and added test for EK80 missing receiver_sampling_freq error [all tests ci]
#1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1234 +/- ##
=======================================
Coverage 83.29% 83.29%
=======================================
Files 64 64
Lines 5675 5675
=======================================
Hits 4727 4727
Misses 948 948
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
leewujung
reviewed
Dec 1, 2023
leewujung
reviewed
Dec 1, 2023
leewujung
reviewed
Dec 1, 2023
leewujung
reviewed
Dec 1, 2023
There was a problem hiding this comment.
@praneethratna : I pushed a change (see comment above) and made 2 small comments on the tests. Once those 2 are added I think this PR is good to go. Thanks for investigating the bug in pad_shorter_ping failure and adding the test!
Co-authored-by: Wu-Jung Lee <[email protected]>
Co-authored-by: Wu-Jung Lee <[email protected]>
leewujung
reviewed
Dec 3, 2023
|
Hey @praneethratna : I just fixed the indent in the test that errored out. I think we're good to go now, so I'll merge this. Thanks! |
leewujung
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed reshape bug in
pad_shorter_pingand added text case to validate the fix for #1217 which was fixed in #1219.CC @leewujung