Overhaul AZFP Environment group
#1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… valid data; add missing mandatory absorption_indicative & sound_speed_indicative vars (currently all nan); and update tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1226 +/- ##
==========================================
- Coverage 83.44% 77.96% -5.49%
==========================================
Files 64 16 -48
Lines 5672 2632 -3040
==========================================
- Hits 4733 2052 -2681
+ Misses 939 580 -359
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
emiliom
changed the title
Environment group
This was referenced Nov 15, 2023
Merged
Ah. Maybe in the next release, the calculation of those parameters can be moved to I'll merge the PR now. Thanks! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully addresses #1225.
I'm not aware of a source of data to populate the
absorption_indicative&sound_speed_indicativevariables, so I'm simply filling them withnp.nan. @leewujung do you know if there's something in the AZFP raw data & XML that could be used? If there isn't, or it's not straightforward, I suggest leaving the variables in withnp.nan; after all, the variables were not present before this PR 😅