Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixtures to generate mock data for clean up use_swap handling #1183

Closed
wants to merge 6 commits into from

Conversation

leewujung
Copy link
Member

@lsetiawan : in this PR you'll find functions that generate mock data for testing the use_swap functionality for #1179.

I made it such that the output is in identical format with parser.ping_data_dict, for timestamp, power, and angle.

See my comment here for more info: #1179 (comment)

Because of the possible variations, I think using both the actual data for integration tests and mock data for unittest will be a good idea.

In terms of actual .raw data that we need to handle, see my previous investigation #489 (comment) and #489 (comment).

@leewujung
Copy link
Member Author

BTW, the tests WILL fail because I only did the short-circuiting to make it easy to see how data looks like without the zarr_datagrams business. I did not try to fix anything downstream, because they need to be removed.

@lsetiawan
Copy link
Member

Merged in #1185

@lsetiawan lsetiawan closed this Oct 2, 2023
@leewujung leewujung deleted the p2z-mock-data branch July 21, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants