Temporarily remove compute_NASC
#1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## dev #1136 +/- ##
==========================================
- Coverage 80.41% 72.04% -8.38%
==========================================
Files 65 4 -61
Lines 6046 186 -5860
==========================================
- Hits 4862 134 -4728
+ Misses 1184 52 -1132
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 61 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Aug 30, 2023
Closed
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily remove
commongrid.compute_NASC, because the current implementation ofcompute_NASCmay contain unintended bugs related to units and a scaling factor. We'll add this back in v0.8.1.