Fix object dtype and cast to string #1072
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1072 +/- ##
===========================================
- Coverage 77.70% 57.54% -20.16%
===========================================
Files 67 18 -49
Lines 6252 1616 -4636
===========================================
- Hits 4858 930 -3928
+ Misses 1394 686 -708
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 53 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
@lsetiawan : thanks for the quick turn-around! I pushed a commit to add cal_channel_id into EXPECTED_VAR_DTYPE since this var will always be of the same type as channel. I think it is good that you added the block to catch other unexpected ones -- I wonder what the xarray rules are to determine when strings are stored as objects or strings?
Also it is great that sanitize_dtypes is now in echodata.__get_dataset!
Feel free to merge once the tests run through!
|
I am going to merge this so that this change gets into |
* Fix object dtype and cast to string * add cal_channel_id to EXPECTED_VAR_DTYPE in utils.coding * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove accidental test code --------- Co-authored-by: Wu-Jung Lee <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Overview
This PR fixes issues with some variable being an
objectdata type, which caused issues during file writing. This PR defaults theobjectdata type to be casted to string.