Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix call to register EK500 colormap #1068

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Fix call to register EK500 colormap #1068

merged 2 commits into from
Jul 19, 2023

Conversation

leewujung
Copy link
Member

This PR fixes the call to register the EK500 colormap per the recent deprecation warning:

The register_cmap function was deprecated in Matplotlib 3.7 and will be removed two minor releases later. Use matplotlib.colormaps.register(name) instead.

@leewujung leewujung added this to the 0.7.2 milestone Jun 25, 2023
@leewujung leewujung requested a review from lsetiawan June 25, 2023 21:07
@leewujung leewujung modified the milestones: 0.8.1, 0.8.0 Jul 15, 2023
@lsetiawan
Copy link
Member

This is great! Thanks! Could you pin the matplotlib to be version >=3.7?

@leewujung
Copy link
Member Author

Pinned. Let me know if we actually need space around the >=...

@leewujung
Copy link
Member Author

Ok i've tested pip install -e ".[plot]" and it does work. I'll merge this now.

@leewujung leewujung merged commit 66bef5c into OSOceanAcoustics:dev Jul 19, 2023
lsetiawan pushed a commit to lsetiawan/echopype that referenced this pull request Jul 28, 2023
@leewujung @lsetiawan
Fix call to register EK500 colormap (OSOceanAcoustics#1068)
f51ebfb 
* update mpl.cm.register_cmap with matplotlib.colormaps.register

* pin matplotlib to >=3.7
@leewujung leewujung deleted the fix-mpl-call branch July 21, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsetiawan lsetiawan lsetiawan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Echopype
Status: Done
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@leewujung @lsetiawan