Impedance type change, name change, bug fix

[leewujung]

This PR contains the following changes:

• change the data type of impedance to float (addresses impedance int > float #1018)
• finish renaming impedance_transmit to impedance_transducer and impedance_receive to impedance_transceiver (leftover that resulted into bug from v0.7.0)
• rename transmit chirp replica construction methods:
  • correct typo Anderson to Andersen
  • change Macaulay to Matlab since original code came from Andersen
  • remove the previous Macaulay chirp replica implementation and only keep the one in reference to Andersen

[codecov-commenter]

Codecov Report

Merging #1019 (8fb39cb) into dev (2736ee9) will decrease coverage by 13.54%.
The diff coverage is 92.30%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##              dev    #1019       +/-   ##
===========================================
- Coverage   80.45%   66.91%   -13.54%     
===========================================
  Files          67       30       -37     
  Lines        6038     3857     -2181     
===========================================
- Hits         4858     2581     -2277     
- Misses       1180     1276       +96     

Flag	Coverage Δ
unittests	66.91% <92.30%> (-13.54%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
echopype/convert/utils/ek_raw_parsers.py	40.59% <ø> (-15.31%)	⬇️
echopype/calibrate/ek80_complex.py	86.95% <66.66%> (ø)
echopype/calibrate/cal_params.py	91.66% <100.00%> (ø)
echopype/calibrate/calibrate_ek.py	97.87% <100.00%> (ø)
echopype/convert/set_groups_ek80.py	83.80% <100.00%> (-12.96%)	⬇️

... and 54 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[emiliom]

change Macaulay to Matlab since original code came from Andersen

I don't know anything about this, but an implementation name of "Matlab" seems not specific enough, unlike Andersen and Macaulay. The Andersen implementation code has a helpful 2-line comment that provides background. Is the "Matlab" implementation from a specific m-script file, from the general Matlab code base, or something else?

[emiliom]

Done reviewing. In addition to my other small comments, I mainly checked for consistency of the variable renaming, impedance_transmit -> impedance_transducer and impedance_receive -> impedance_transceiver. I didn't find any errors (inconsistencies).

[leewujung]

Is the "Matlab" implementation from a specific m-script file, from the general Matlab code base, or something else?

The "Matlab" implementation came from Lars Andersen in matlab Echolab code that was passed through multiple people (I got it from Chu).

In fact, I think the best way to do this is to remove this implementation completely. I spoked with Lars about this and the specific chirp implementation is due to the implementation in hardware, so we should stick to it.

[leewujung]

@emiliom : I've added type hint to z_et and z_er. Also added a source reference to the gain correction based on angle offset and beamwidth that was undocumented anywhere else -- I asked Lars about it and added the explanation in the docstring.

Let me know what you think about the "Matlab" implementation of chirp.

[emiliom]

The "Matlab" implementation came from Lars Andersen in matlab Echolab code that was passed through multiple people (I got it from Chu).

👍

In fact, I think the best way to do this is to remove this implementation completely. I spoked with Lars about this and the specific chirp implementation is due to the implementation in hardware, so we should stick to it.

Well, the issue goes away if you remove the "Matlab" implementation 😉. So, no additional comment here. It's up to you whether to keep it or not. If you do keep it, my suggestion would be to simply change the label to something like "MatlabEcholab" and add a comment like the sentence above describing its origin.

[leewujung]

I think I'll opt for removing that section entirely, since it does not have the simplicity of just using a general chirp function, nor does it conform with what Simrad actually uses. I'll push up a commit for the removal.