Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Simple Indexing for Noise and Attenuation Function Aggregations/Comparisons #1321

Closed
ctuguinay opened this issue May 28, 2024 · 0 comments · Fixed by #1326
Closed

Use Simple Indexing for Noise and Attenuation Function Aggregations/Comparisons #1321

ctuguinay opened this issue May 28, 2024 · 0 comments · Fixed by #1326
Assignees
Labels
enhancement This makes echopype better
Milestone

Comments

@ctuguinay
Copy link
Collaborator

ctuguinay commented May 28, 2024

This issue addresses the performance issue encountered in the #1314 noise and attenuation masking functions, which comes from the aggregations in the masking functions being those where the selection of depth is assumed to be non-uniform across channel and ping time. This forces us to basically do a 'where depth meets this criteria' check to create our aggregations instead of doing something fast and index-based like .coarsen.

From @leewujung in #1314 discussion:

All of the criteria are built on the concept of comparing with neighbors, and the binning from accurate bin edges (from the coordinate labels) vs inaccurate bin edges (from just the indices) would likely result in pretty small differences. If the noise needs to be masked, it would get masked either way; if the noise is borderline, the masking is likely be at least equally sensitive to other independent parameter changes (such as changing the averaging bin size along depth or across pings).

I envision implementing a fast indexed version of these functions by allowing the user to pass in use_index_binning=True/False into each of the existing functions and right before an aggregation occurs in the masking function, we choose between a .coarsen like function and the slow aggregations that we currently have from #1314 (based on use_index_binning).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This makes echopype better
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant