Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Noise and Attenuation Functions from Ryan et. al. 2015 #1314

Closed
3 tasks done
ctuguinay opened this issue Apr 30, 2024 · 1 comment · Fixed by #1316
Closed
3 tasks done

Implement Noise and Attenuation Functions from Ryan et. al. 2015 #1314

ctuguinay opened this issue Apr 30, 2024 · 1 comment · Fixed by #1316
Assignees
Milestone

Comments

@ctuguinay
Copy link
Collaborator

ctuguinay commented Apr 30, 2024

From Reducing bias due to noise and attenuation in open-ocean echo integration data, implement the following noise filters:

  • IN filter
  • AS filter
  • TN filter

Implementation of some (if not all) of these filters can be found in echopy written in pure numpy. We want to implement these filters using Xarray, and if Dask Delaying is not too involved, implement that as well. If not, we can write a separate issue for that.

@ctuguinay ctuguinay added this to the v0.9.0 milestone Apr 30, 2024
@ctuguinay ctuguinay self-assigned this Apr 30, 2024
@github-project-automation github-project-automation bot moved this to Todo in Echopype Apr 30, 2024
@ctuguinay
Copy link
Collaborator Author

Related to #1211, since the existing noise functions will have to be renamed to something more specific.

@ctuguinay ctuguinay changed the title Implement Noise Functions from Ryan et. al. Implement Noise Functions from Ryan et. al. 2015 May 4, 2024
@ctuguinay ctuguinay changed the title Implement Noise Functions from Ryan et. al. 2015 Implement Noise and Attenuation Functions from Ryan et. al. 2015 May 4, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Echopype May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant