Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused variables should be removed #18

Closed
schwehr opened this issue Feb 6, 2021 · 2 comments
Closed

Unused variables should be removed #18

schwehr opened this issue Feb 6, 2021 · 2 comments
Assignees
@schwehr

Comments

@schwehr
Copy link
Member

schwehr commented Feb 6, 2021

Follow up to #17 , I am going to split out tasks starting with easier / less controversial (I hope)

The first one is that there are quite a few unused variables, especially in contrib. Most of these look like copy/paste remnants. Others are more tricky. e.g. defined in one place, set in one or more places, and never used.
@schwehr schwehr self-assigned this Feb 6, 2021
schwehr added a commit that referenced this issue Feb 6, 2021
@schwehr
Remove unused variables [#18]
105aa26 
These are the easy ones found with cppcheck.

contrib/

dbfcat.c dbfinfo.c shpcentrd.c shpdata.c shpdxf.c shpgeo.c shpinfo.c shpwkb.c
schwehr added a commit that referenced this issue Feb 7, 2021
@schwehr
Merge pull request #19 from OSGeo/schwehr-unused-variables
28ffc4e 
Remove unused variables [#18]
@thbeu
Copy link
Contributor

thbeu commented Nov 6, 2023

@schwehr Anything left to do here?

@schwehr
Copy link
Member Author

schwehr commented Nov 7, 2023

Thanks for the ping. I thiink I got most everythin. Closing.

@schwehr schwehr closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schwehr schwehr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schwehr @thbeu