-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib/diglib: calculate the total size of topo file to get the correct off_t_size #3351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metzm
reviewed
Jan 10, 2024
metzm
reviewed
Jan 10, 2024
metzm
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this bugfix!
This PR is approved and reviewed. Is there anything that should block merging this? |
neteler
pushed a commit
that referenced
this pull request
Feb 2, 2024
…t_size (#3351) * diglib: Calculate the total size of topo file to get the correct off_t_size * Add doxygen API doc for dig_Wr_Plus_head() * cast long PORT_LONG_MAX into off_t
jadenabrams100
pushed a commit
to ncsu-csc472-spring2024/grass-CI-playground
that referenced
this pull request
Feb 21, 2024
…t_size (OSGeo#3351) * diglib: Calculate the total size of topo file to get the correct off_t_size * Add doxygen API doc for dig_Wr_Plus_head() * cast long PORT_LONG_MAX into off_t
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a new PR for #3163 (accidentally merged instead of rebase).
off_t
sizes for coor and topo files can be different. For example, from an EPSG:4326 location,coor_size
is less thanPORT_LONG_MAX
(2^31 - 1 = 2147483647; maxint
), but the topo size is greater than that. Settingptr->off_t_size = 4
ingrass/lib/vector/diglib/plus_struct.c
Lines 677 to 682 in fd59e94
ptr->Isle_offset
is read as -2121341854 ingrass/lib/vector/diglib/plus_struct.c
Line 641 in fd59e94
This PR calculates the total size of topo file to get the correct
off_t_size
. Before this PR, the size of coor file was used to determine this offset size for topo file.