-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Update labeler’s labels #3349
Conversation
Co-authored-by: Markus Neteler <[email protected]>
If it's correct, add the approval and set the automerge and done! |
How about to map the directories in scripts based on the prefix? |
I see them now. What is the difference between those in scripts rather than in their respective folders? |
Python based. |
And vs in the python/grass/(module type name)/ folders? There's something by about imaging and temporal there |
I would leave that out. |
I was trying to understand the fine-details of the project's folder structure, to know if the script folder might be superfluous, if some of the code is also tucked inside the python/grass/ folder. |
I think you meant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good improvement. We may revisit and fine-tune it in future after some time, as needed.
Looks good to me, good to go! In case you want to fine-tune, the following may be added: display:
- changed-files:
- any-glob-to-any-file:
- display/**/*
general:
- changed-files:
- any-glob-to-any-file:
- general/**/*
misc:
- changed-files:
- any-glob-to-any-file:
- misc/**/* and map the following:
|
On a second thought, since I think the use cases for the labels could be either to help finding issues that matches a reviewer's expertises, or to eventually help out with releasing/release notes, or simply to give a high level overview of what is touched, I removed the Markdown section. It is already redundant with the docs label, and it doesn't really bring a value to discriminate between the expertise needed. If you see a PR with only docs as a label, it's a docs only change, if it is docs and modules and a category, the PR updates the documentation of a module. I didn't remove yet the HTML, as I didn't search yet if there is a template (like for docs) that might necessitate a web expertise. Same thing for CSS and JavaScript, these are different expertises. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
(The "binder" and "pre-commit" parts are questionable, but CI is close enough).
Ya, but I wasn't able to find a better place, and it isn't "build" neither. So I falled back to "who would review this?", and it's about the same as the other code quality and building infrastructure as CI. |
As promised, a little follow-up on the labeler’s labels.
Was missing imagery and raster3d.
Added patterns to match for files of a module inside a the lib folder.
Excluded RFC to not match Markdown or docs.
One of my goals was to have the docs label match when it is a docs-only PR, that could be quicker to review