Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wxGUI/preferences: allow the user to change the font size/face of the manual page #3291

Merged
merged 2 commits into from
Dec 8, 2023
Merged

wxGUI/preferences: allow the user to change the font size/face of the manual page #3291

merged 2 commits into from
Dec 8, 2023

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Dec 6, 2023 •
edited
Loading

Implementing/close feature #3268.

wxgui_preferences_allow_user_setting_man_page_font_size_face.mp4

@tmszi tmszi added enhancement New feature or request GUI wxGUI related manual Documentation related issues labels Dec 6, 2023
@tmszi tmszi added this to the 8.4.0 milestone Dec 6, 2023
@tmszi tmszi self-assigned this Dec 6, 2023
@tmszi tmszi linked an issue Dec 6, 2023 that may be closed by this pull request
way to change text size in wxGUI manual pages #3268
Closed
petrasovaa
petrasovaa approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@tmszi tmszi merged commit 7d99ee3 into OSGeo:main Dec 8, 2023
@tmszi tmszi deleted the wxgui-preferences-allow-setting-module-man-page-font-size branch December 8, 2023 07:44
@cmbarton
Copy link
Contributor

cmbarton commented Dec 8, 2023

This looks GREAT! Thanks much. My eyes (and those of many others) thank you.

@cmbarton
Copy link
Contributor

cmbarton commented Dec 8, 2023

Just now compiled and tested. Works as intended. However, it generates a (bogus?) error in the terminal:

2023-12-08 15:46:28.493 python[17294:11493842] CoreText note: Client requested name ".SFNS-Regular", it will get TimesNewRomanPSMT rather than the intended font. All system UI font access should be through proper APIs such as CTFontCreateUIFontForLanguage() or +[NSFont systemFontOfSize:].

I picked Calibri on my Mac and it seems to show Calibri regardless of the error claiming that I'll see Times New Roman.

@cmbarton
Copy link
Contributor

cmbarton commented Dec 8, 2023

I just did it a second time and there is no error. Maybe once I save and it creates an entry in the GUI data file there is no longer an error.

HuidaeCho pushed a commit to HuidaeCho/grass that referenced this pull request Jan 9, 2024
@tmszi @HuidaeCho
wxGUI/preferences: allow the user to change the font size/face of the…
2749e39 
… manual page (OSGeo#3291)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrasovaa petrasovaa petrasovaa approved these changes

Assignees

@tmszi tmszi

Labels
enhancement New feature or request GUI wxGUI related manual Documentation related issues
Projects
None yet
Milestone
8.4.0
Development

Successfully merging this pull request may close these issues.

way to change text size in wxGUI manual pages
3 participants
@tmszi @cmbarton @petrasovaa