Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v.db.join: Add exclude_columns= option #3174

Merged
merged 1 commit into from
Nov 19, 2023
Merged

v.db.join: Add exclude_columns= option #3174

merged 1 commit into from
Nov 19, 2023

Conversation

HuidaeCho
Copy link
Member

This PR adds exclude_columns= option to exclude certain columns from other table (e.g., cat).

@HuidaeCho HuidaeCho added enhancement New feature or request vector Related to vector data processing database Related to database management labels Sep 22, 2023
@HuidaeCho
Copy link
Member Author

BTW, overwriting cat is dangerous in general. If other table is the attribute table of another vector, we should exclude cat automatically?

@neteler neteler added this to the 8.4.0 milestone Oct 5, 2023
wenzeslaus
wenzeslaus approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm for merging this as is and fixing the cat column issue separately.

@landam
Copy link
Member

landam commented Nov 19, 2023

@HuidaeCho Are you going to merge this PR?

@HuidaeCho
Copy link
Member Author

@HuidaeCho Are you going to merge this PR?

Yes. Doing it now. Thanks for the reminder!

@HuidaeCho HuidaeCho merged commit 97da922 into OSGeo:main Nov 19, 2023
@HuidaeCho HuidaeCho mentioned this pull request Nov 19, 2023
Open
HuidaeCho added a commit to HuidaeCho/grass that referenced this pull request Jan 9, 2024
@HuidaeCho
v.db.join: Add exclude_columns= option (OSGeo#3174)
d49cb6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenzeslaus wenzeslaus wenzeslaus approved these changes

Assignees

@HuidaeCho HuidaeCho

Labels
database Related to database management enhancement New feature or request vector Related to vector data processing
Projects
None yet
Milestone
8.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@HuidaeCho @landam @wenzeslaus @neteler